Enable TreatWarningsAsErrors only on CI #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We raised the severity of some rules from message to warning to ensure they are followed in the team but because of the `TreatWarningsAsErrors` we end up with some "boring" dev cycles where we are forced to cleanup usings etc while we iterate. The idea is to keep warnings locally to not slow us down but still fail in PRs so that we can keep styling consistency.
Evangelink
commented
Feb 7, 2022
| @@ -20,7 +20,9 @@ | |||
| serialization. This is also defined in build script. --> | |||
| <AssemblyVersion Condition="'$(AssemblyVersion)' == ''">15.0.0</AssemblyVersion> | |||
|
|
|||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | |||
| <!-- Treat warnings as errors only on CI to prevent painful development process because of unused usings... --> | |||
| <TreatWarningsAsErrors Condition="'$(CIBuild)' == 'true'">true</TreatWarningsAsErrors> | |||
There was a problem hiding this comment.
@nohwnd I remember you asked if we could disable in draft PRs but except from using github api I couldn't find something already in place.
MarcoRossignoli
approved these changes
Feb 7, 2022
|
I hope it will reduce some pain :P |
eh...it depends we work usually to have "local as CI" here we're trying to impose the opposite, I think it's ok...let's see how many time we found the "surprise" in the CI...in the night 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We raised the severity of some rules from message to warning to ensure they are followed in the team but because of the
TreatWarningsAsErrorswe end up with some "boring" dev cycles where we are forced to cleanup usings etc while we iterate. The idea is to keep warnings locally to not slow us down but still fail in PRs so that we can keep styling consistency.cc @nohwnd @MarcoRossignoli