Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry improvements #3340

Merged
merged 7 commits into from
Feb 11, 2022
Merged

Telemetry improvements #3340

merged 7 commits into from
Feb 11, 2022

Conversation

cvpoienaru
Copy link
Member

@cvpoienaru cvpoienaru commented Feb 8, 2022 •
edited
Loading

Telemetry improvements

@MarcoRossignoli
Copy link
Contributor

@cvpoienaru looks like you've some conflicts

@MarcoRossignoli
Copy link
Contributor

@cvpoienaru will you update this PR or our discussion is for follow-up PRs?

@cvpoienaru
Copy link
Member Author

@cvpoienaru will you update this PR or our discussion is for follow-up PRs?

@MarcoRossignoli I'll create a follow up PR for that because this one is getting too large already.

@cvpoienaru cvpoienaru changed the title Telemetry improvements for Test Sessions Telemetry improvements Feb 10, 2022
Evangelink
Evangelink reviewed Feb 11, 2022
View reviewed changes
src/Microsoft.TestPlatform.Common/PublicAPI/PublicAPI.Shipped.txt Show resolved Hide resolved
src/Microsoft.TestPlatform.Common/Telemetry/TelemetryDataConstants.cs Show resolved Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/PublicAPI/PublicAPI.Shipped.txt Show resolved Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/TestSession/ProxyTestSessionManager.cs Outdated Show resolved Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/TestSession/ProxyTestSessionManager.cs Outdated Show resolved Hide resolved
src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/TestSession.cs Show resolved Hide resolved
src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/TestSession.cs Show resolved Hide resolved
src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleWrapper.cs Show resolved Hide resolved
src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleWrapper.cs Show resolved Hide resolved
test/TranslationLayer.UnitTests/TestSessionTests.cs Outdated Show resolved Hide resolved
@cvpoienaru cvpoienaru enabled auto-merge (squash) February 11, 2022 15:46
Evangelink
Evangelink approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One small suggestion still open but feel free to ignore it.

@cvpoienaru
Copy link
Member Author

LGTM!

One small suggestion still open but feel free to ignore it.

Fixed as discussed offline.

MarcoRossignoli
MarcoRossignoli approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

src/Microsoft.TestPlatform.Client/PublicAPI/PublicAPI.Unshipped.txt Show resolved Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/PublicAPI/PublicAPI.Unshipped.txt Show resolved Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/TestEngine.cs Show resolved Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/TestEngine.cs Show resolved Hide resolved
src/Microsoft.TestPlatform.ObjectModel/Client/Events/StartTestSessionCompleteEventArgs.cs Show resolved Hide resolved
...crosoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/IVsTestConsoleWrapperAsync.cs Show resolved Hide resolved
src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/PublicAPI/PublicAPI.Unshipped.txt Show resolved Hide resolved
src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/TestSession.cs Show resolved Hide resolved
src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleWrapper.cs Show resolved Hide resolved
src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleWrapper.cs Show resolved Hide resolved
@cvpoienaru cvpoienaru merged commit 64730b5 into microsoft:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoRossignoli MarcoRossignoli MarcoRossignoli approved these changes

@Evangelink Evangelink Evangelink approved these changes

@nohwnd nohwnd Awaiting requested review from nohwnd nohwnd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cvpoienaru @MarcoRossignoli @Evangelink