-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable even more rules #3356
Enable even more rules #3356
Conversation
For some reason they don't get reported in the CI.
we're missing only the null ref annotations...maybe we can start for new files/types(file context) and put some effort project by project...it could be a long task. |
I have a branch for it but that's pretty big effort. One solution could be to go with enable nullable and annotate all existing file with the disable so that every new added file follows nullable pattern and we could work on enabling it partially on existing files at a slower pace. |
@nohwnd Is it ok to squash and merge here? |
I think it's good...it's a great improvement anyway. |
cc @MarcoRossignoli