Add ARM64 .NET Framework testhost #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
Feb 15, 2022
| @@ -880,6 +883,18 @@ Global | |||
| {B6AF6BCD-64C6-4F4E-ABCA-C8AA2AA66B7B}.Release|x64.Build.0 = Release|Any CPU | |||
| {B6AF6BCD-64C6-4F4E-ABCA-C8AA2AA66B7B}.Release|x86.ActiveCfg = Release|Any CPU | |||
| {B6AF6BCD-64C6-4F4E-ABCA-C8AA2AA66B7B}.Release|x86.Build.0 = Release|Any CPU | |||
| {186069FE-E1E8-4DE1-BEA4-0FF1484D22D1}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | |||
There was a problem hiding this comment.
I see that we are doing the same thing for testhost and testhost.x86 but I am still surprised. Why do we compile in AnyCpu if that's a platform specific exe?
There was a problem hiding this comment.
I don't know exactly. It is probably done out of habit. We ngen these when inserting into VS, but not when inserting into dotnet sdk.
Evangelink
reviewed
Feb 15, 2022
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DefaultTestHostManager.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DefaultTestHostManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DefaultTestHostManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DefaultTestHostManager.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Feb 16, 2022
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DefaultTestHostManager.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Feb 16, 2022
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DefaultTestHostManager.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Feb 16, 2022
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DefaultTestHostManager.cs
Show resolved
Hide resolved
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Evangelink
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add arm64 testhost for .NET Framework.