Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ci switch for Windows and Windows-Acceptance #3372

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Add ci switch for Windows and Windows-Acceptance #3372

merged 2 commits into from
Feb 15, 2022

Conversation

Evangelink
Copy link
Member

@Evangelink Evangelink commented Feb 15, 2022 •
edited
Loading

Description

Make sure -ci switch is passed for Windows and Windows-Acceptance, this ensures we have TreatWarningsAsErrors on windows builds.

Haplois
Haplois suggested changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@Haplois Haplois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a step to disable strong name validation.

@Haplois Haplois enabled auto-merge (squash) February 15, 2022 18:30
@Haplois Haplois merged commit 03c9114 into microsoft:main Feb 15, 2022
@Evangelink Evangelink deleted the pipeline branch February 16, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haplois Haplois Haplois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Evangelink @Haplois