Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix singleton #3389

Merged
merged 4 commits into from
Feb 20, 2022
Merged

Fix singleton #3389

merged 4 commits into from
Feb 20, 2022

Conversation

Evangelink
Copy link
Member

No description provided.

MarcoRossignoli and others added 3 commits February 20, 2022 11:46
…g/FeatureFlagTests.cs

Co-authored-by: Jakub Jareš <me@jakubjares.com>
…ag.cs

Co-authored-by: Jakub Jareš <me@jakubjares.com>
@MarcoRossignoli MarcoRossignoli enabled auto-merge (squash) February 20, 2022 11:02
@MarcoRossignoli
Copy link
Contributor

MarcoRossignoli commented Feb 20, 2022

Thx @Evangelink missed that one, feature flag bag is immutable by design so it didn't fail any test and also maybe singleton is not needed here(transient is good also), but let's keep the style, too sugars in this C# 😄

I wonder why we're not rewriting all plat in F# 😉

@MarcoRossignoli MarcoRossignoli merged commit cdb0e0c into microsoft:main Feb 20, 2022
@Evangelink Evangelink deleted the fix-singleton branch February 21, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants