Revert part of #3422 (Remove PlatformEqtTrace.Instance) #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #3422 we moved the creation of the
PlatformEqtTraceinside theMicrosoft.TestPlatform.PlatformAbstractions.dllto be able to log information from it.Unfortunately this update broke a scenario where we're loading inside the test host an old version of
Microsoft.TestPlatform.PlatformAbstractions.dll(the one close to the runner) and the newMicrosoft.TestPlatform.ObjectModel.dllclose to the test container.This ends with a MissingMethodException because the old dll doesn't have the expected method.
The specific scenario is:
Runner: microsoft.testplatform.16.7.0-preview-20200519-01
TestAdapter: mstest.testadapter.2.1.0
Object model close to the user container: 17.2.0-preview-20220311-01
cc: @AbhitejJohn