Fix logging setup when running in remote #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In remote scenario we can be passed path surrounded with quotes from parameters, and we should ignore those extra quotes. We should also create the full path for log, because in local run vstest.console handles that for us, and so testhost always has the full path, but in remote run the folder is not there and setting up logs fails, and nothing is logged
Evangelink
reviewed
May 16, 2022
| @@ -161,6 +161,9 @@ public static bool InitializeVerboseTrace(string customLogFile) | |||
| /// <returns>Trace initialized flag.</returns> | |||
| public static bool InitializeTrace(string customLogFile, PlatformTraceLevel traceLevel) | |||
| { | |||
| // Remove extra quotes if we get them passed on the parameter, | |||
| // System.IO.File does not ingore them when checking the file existence. | |||
There was a problem hiding this comment.
Suggested change
| // System.IO.File does not ingore them when checking the file existence. | |
| // System.IO.File does not ignore them when checking the file existence. |
Evangelink
reviewed
May 16, 2022
Comment on lines
372
to
376
| var runnlerLogFileInfo = new FileInfo(runnerLogFileName); | ||
| if (!Directory.Exists(runnlerLogFileInfo.DirectoryName)) | ||
| { | ||
| Directory.CreateDirectory(runnlerLogFileInfo.DirectoryName); | ||
| } |
There was a problem hiding this comment.
Suggested change
| var runnlerLogFileInfo = new FileInfo(runnerLogFileName); | |
| if (!Directory.Exists(runnlerLogFileInfo.DirectoryName)) | |
| { | |
| Directory.CreateDirectory(runnlerLogFileInfo.DirectoryName); | |
| } | |
| var runnerLogFileInfo = new FileInfo(runnerLogFileName); | |
| if (!Directory.Exists(runnerLogFileInfo.DirectoryName)) | |
| { | |
| Directory.CreateDirectory(runnerLogFileInfo.DirectoryName); | |
| } |
Evangelink
approved these changes
May 16, 2022
|
/azp run |
|
Not sure if that is just flaky. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Evangelink
approved these changes
Jun 9, 2022
| @@ -367,6 +367,12 @@ private static bool EnsureTraceIsInitialized() | |||
| runnerLogFileName = LogFile; | |||
| } | |||
|
|
|||
| var runnerLogFileInfo = new FileInfo(runnerLogFileName); | |||
| if (!Directory.Exists(runnerLogFileInfo.DirectoryName)) | |||
There was a problem hiding this comment.
Nit: You could do runnerLogFileInfo.Directory.Exists instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In remote scenario we can be passed path surrounded with quotes from parameters, and we should ignore those extra quotes. We should also create the full path for log, because in local run vstest.console handles that for us, and so testhost always has the full path, but in remote run the folder is not there and setting up logs fails, and nothing is logged