Minor optimizations #3687
Merged
Minor optimizations #3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
commented
May 27, 2022
src/Microsoft.TestPlatform.Common/Logging/InternalTestLoggerEvents.cs
Outdated
Show resolved
Hide resolved
nohwnd
commented
May 27, 2022
src/Microsoft.TestPlatform.CommunicationUtilities/JsonDataSerializer.cs
Outdated
Show resolved
Hide resolved
nohwnd
commented
May 27, 2022
| { | ||
| #if DEBUG && (NETFRAMEWORK || NET || NETSTANDARD2_0_OR_GREATER) |
There was a problem hiding this comment.
Seemed to work okay, but not worth the risk of breaking this in production.
nohwnd
commented
May 27, 2022
src/Microsoft.TestPlatform.CoreUtilities/Utilities/MulticastDelegateUtilities.cs
Show resolved
Hide resolved
nohwnd
commented
May 27, 2022
| RunSettingsUtilities.CreateAndInitializeRunSettings(discoveryCriteria.RunSettings), | ||
| discoveryCriteria.TestCaseFilter, | ||
| _sessionMessageLogger); | ||
| var runSettings = RunSettingsUtilities.CreateAndInitializeRunSettings(discoveryCriteria.RunSettings); |
There was a problem hiding this comment.
This did a lot in the the method call. This way it is much easier to see what is passed on.
nohwnd
force-pushed
the
multi-tfm-perf-optimizations
branch
from
c43015c to
aec5bcc
Compare
Evangelink
approved these changes
May 30, 2022
src/Microsoft.TestPlatform.CommunicationUtilities/JsonDataSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CoreUtilities/Utilities/MulticastDelegateUtilities.cs
Show resolved
Hide resolved
Evangelink
approved these changes
Jun 1, 2022
Evangelink
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some minor optimizations