Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nullable on adapter utilities #3688

Merged
merged 3 commits into from
May 30, 2022
Merged

Enable nullable on adapter utilities #3688

merged 3 commits into from
May 30, 2022

Conversation

Evangelink
Copy link
Member

@Evangelink Evangelink commented May 30, 2022 •
edited
Loading

Contributes to AB#1549371

Haplois
Haplois suggested changes May 30, 2022
View reviewed changes
Copy link
Contributor

@Haplois Haplois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments about nullability.

src/Microsoft.TestPlatform.AdapterUtilities/ManagedNameUtilities/InvalidManagedNameException.cs Outdated Show resolved Hide resolved
...Microsoft.TestPlatform.AdapterUtilities/ManagedNameUtilities/ManagedNameHelper.Reflection.cs Show resolved Hide resolved
...Microsoft.TestPlatform.AdapterUtilities/ManagedNameUtilities/ManagedNameHelper.Reflection.cs Outdated Show resolved Hide resolved
...Microsoft.TestPlatform.AdapterUtilities/ManagedNameUtilities/ManagedNameHelper.Reflection.cs Outdated Show resolved Hide resolved
src/Microsoft.TestPlatform.AdapterUtilities/ManagedNameUtilities/ManagedNameParser.cs Show resolved Hide resolved
...Microsoft.TestPlatform.AdapterUtilities/ManagedNameUtilities/ManagedNameHelper.Reflection.cs Outdated Show resolved Hide resolved
...Microsoft.TestPlatform.AdapterUtilities/ManagedNameUtilities/ManagedNameHelper.Reflection.cs Show resolved Hide resolved
src/Microsoft.TestPlatform.AdapterUtilities/PublicAPI/PublicAPI.Shipped.txt Outdated Show resolved Hide resolved
@Evangelink Evangelink enabled auto-merge (squash) May 30, 2022 11:11
@Evangelink Evangelink merged commit fe3a8d3 into microsoft:main May 30, 2022
@nohwnd
Copy link
Member

nohwnd commented May 30, 2022

Looks fine. Would've liked to see the TODO: addressed as well, but won't block on that.

@Evangelink Evangelink deleted the testadapter-utilities-nullable branch May 30, 2022 12:57
@Evangelink
Copy link
Member Author

TODOs will be addressed by @Haplois on a different PR he is currently working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nohwnd nohwnd nohwnd approved these changes

@Haplois Haplois Haplois approved these changes

@MarcoRossignoli MarcoRossignoli Awaiting requested review from MarcoRossignoli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Evangelink @nohwnd @Haplois