Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable name in common.lib.ps1 #3985

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Fix variable name in common.lib.ps1 #3985

merged 1 commit into from
Sep 1, 2022

Conversation

Haplois
Copy link
Contributor

@Haplois Haplois commented Sep 1, 2022 •
edited
Loading

Issue is on line 388: $process.remove_ErrorDataReceived($errorDataReceived).

Variable name was wrong.

@Haplois Haplois enabled auto-merge (squash) September 1, 2022 09:45
@nohwnd nohwnd changed the title Fixed a small bug in the script. Fix variable name in common.lib.ps1 Sep 1, 2022
@nohwnd nohwnd disabled auto-merge September 1, 2022 09:51
@nohwnd nohwnd changed the title Fix variable name in common.lib.ps1 Fixed a small bug in the script. Sep 1, 2022
@nohwnd
Copy link
Member

nohwnd commented Sep 1, 2022

Variable name was wrong.

What does it mean it was wrong? Is the name just incorrect in relation to the data it holds?

@nohwnd nohwnd changed the title Fixed a small bug in the script. Fix variable name in common.lib.ps1 Sep 1, 2022
@Haplois
Copy link
Contributor Author

Haplois commented Sep 1, 2022 •
edited by nohwnd
Loading

What does it mean it was wrong

Original name was $errorDataReceivedEvent, but we were trying to remove $errorDataReceived.

@nohwnd
Copy link
Member

nohwnd commented Sep 1, 2022

but we were trying to remove $errorDataReceived.

Where? Am I blind?

I only see $errorDataReceivedEvent used in definition and in use with _add and they both have the same name.

image

@Haplois
Copy link
Contributor Author

Haplois commented Sep 1, 2022

image

@nohwnd nohwnd merged commit 99e22f7 into main Sep 1, 2022
@nohwnd nohwnd deleted the dev/haplois/powershell-script-fix branch September 1, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhnaseer fhnaseer fhnaseer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Haplois @nohwnd @fhnaseer