Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Selenium test run hang after stopping the debugger #3995

Merged
merged 5 commits into from
Sep 8, 2022
Merged

Fixed Selenium test run hang after stopping the debugger #3995

merged 5 commits into from
Sep 8, 2022

Conversation

cvpoienaru
Copy link
Member

Fixed Selenium test run hang after stopping the debugger

@Evangelink
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cvpoienaru
Copy link
Member Author

/azp run

@cvpoienaru cvpoienaru enabled auto-merge (squash) September 7, 2022 16:19
Evangelink
Evangelink approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, I am approving/merging this PR right now without automated tests (we manually tested it) so we can ship the bug fix to customers. We will be working on adding the missing integration tests right after the release.

@cvpoienaru cvpoienaru merged commit 0662d07 into microsoft:main Sep 8, 2022
@cvpoienaru
Copy link
Member Author

Thanks, Amaury ! Linking here the Github issue I'll use to keep track of the remaining work.

cvpoienaru added a commit that referenced this pull request Sep 14, 2022
@cvpoienaru
Fixed Selenium test run hang after stopping the debugger (#4013)
dd7c26b 
* Fixed Selenium test run hang after stopping the debugger (#3995)

* Rebranded TP version to 17.3.2

* Pipeline fix

Co-authored-by: Codrin Poienaru <copoiena@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoRossignoli MarcoRossignoli MarcoRossignoli left review comments

@nohwnd nohwnd nohwnd left review comments

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cvpoienaru @Evangelink @nohwnd @MarcoRossignoli