Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ManagedNameHelper to support namespaceless methods. #4003

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Fix ManagedNameHelper to support namespaceless methods. #4003

merged 1 commit into from
Sep 13, 2022

Conversation

Haplois
Copy link
Contributor

@Haplois Haplois commented Sep 9, 2022

No description provided.

Evangelink
Evangelink reviewed Sep 9, 2022
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests so we don't regress.

@Haplois Haplois marked this pull request as draft September 9, 2022 16:05
@Haplois Haplois marked this pull request as ready for review September 10, 2022 19:09
@Haplois Haplois enabled auto-merge (squash) September 10, 2022 20:06
@Haplois Haplois merged commit 721fa86 into main Sep 13, 2022
@Haplois Haplois deleted the dev/haplois/fqn branch September 13, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Haplois @Evangelink