Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Fix signature verification" (#4333" (#4345 #4345

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Revert "Revert "Fix signature verification" (#4333" (#4345 #4345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49419e5
Revert "Revert "Fix signature verification" (#4333"
nohwnd Mar 20, 2023
15f2f71
Update verify-sign.ps1
nohwnd Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions scripts/verify-sign.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ function Verify-Assemblies
elseif ($signature.SignerCertificate.Subject -eq "CN=Microsoft 3rd Party Application Component, O=Microsoft Corporation, L=Redmond, S=Washington, C=US") {
Write-Debug "Valid ($($signature.SignerCertificate.Thumbprint)): $Path [3rd Party]"
}
elseif ($signature.SignerCertificate.Subject -eq "CN=Microsoft Windows, O=Microsoft Corporation, L=Redmond, S=Washington, C=US") {
# We see this on server only, review what is the actual signature on the dlls we ship.
Write-Debug "Valid ($($signature.SignerCertificate.Thumbprint)): $Path [???]"
}
else {
# For legacy components, sign certificate is always "prod" signature. Skip such binaries.
if ($signature.SignerCertificate.Thumbprint -eq "98ED99A67886D020C564923B7DF25E9AC019DF26") {
Expand Down