Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rel/17.6] Disable pre-start of testhosts #4554

Merged
merged 2 commits into from
Jun 15, 2023
+2 −6
Merged

[rel/17.6] Disable pre-start of testhosts #4554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f84ae19
Disable pre-start to avoid exhausting CPU when there is no subscriber…
nohwnd Jun 15, 2023
83b13bb
Revert change that was done for pre-start
nohwnd Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.TestPlatform.CrossPlatEngine/Client/Parallel/ParallelOperationManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client;
/// </summary>
internal sealed class ParallelOperationManager<TManager, TEventHandler, TWorkload> : IDisposable
{
private const int PreStart = 2;
private const int PreStart = 0;
private readonly static int VSTEST_HOSTPRESTART_COUNT =
int.TryParse(
Environment.GetEnvironmentVariable(nameof(VSTEST_HOSTPRESTART_COUNT)),
Expand Down
6 changes: 1 addition & 5 deletions ...tPlatform.CrossPlatEngine.UnitTests/Client/Parallel/ParallelProxyExecutionManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,11 +285,7 @@ public void StartTestRunShouldProcessAllSourcesOnExecutionAbortsForAnySource()

Assert.IsTrue(_executionCompleted.Wait(Timeout3Seconds), "Test run not completed.");

// Even though we start the test run for two sources, because of the current setup where
// we initialize a proxy if no more slots are available, we end up with abort notice being
// sent only to the running manager. This leaves the initialized manager in limbo and the
// assert will fail because of this.
Assert.AreEqual(1, _processedSources.Count, "Abort should stop all sources execution.");
Assert.AreEqual(2, _processedSources.Count, "Abort should stop all sources execution.");
}

[TestMethod]
Expand Down