Fix executable bitness for testhost.x86 #4652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
approved these changes
Aug 11, 2023
nohwnd
changed the title
Evangelink
reviewed
Aug 14, 2023
| @@ -0,0 +1,8 @@ | |||
| Get-ChildItem S:\p\vstest3\artifacts\packages\Debug\Shipping -Filter vstest.console.exe -Recurse -Force | ForEach-Object { | |||
There was a problem hiding this comment.
Isn't this path linked to your machine setup?
There was a problem hiding this comment.
Yes I am aware of that, answer to all the same questions below is in the PR description. I just did not want to lose that code.
Will plug that script later into build, IDK if both those tools are on hosted images, and on everyones computers.
src/DataCollectors/DumpMinitool.arm64/DumpMinitool.arm64.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nohwnd
added a commit
to nohwnd/vstest
that referenced
this pull request
Aug 14, 2023
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
cvpoienaru
pushed a commit
that referenced
this pull request
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes those issues in 17.8.0 but we need to backport and release 17.7.1:
Related #4650
Related AB#1866640'
Related #4645
Remove + from the final version.
Fix the bitness of our executables. Will plug that script later into build, IDK if both those tools are on hosted images, and on everyones computers.