Fix two source-build poison leaks #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaMilosavljevic
requested review from
mthalman,
MichaelSimons,
mmitche,
nohwnd and
Evangelink
Evangelink
approved these changes
Oct 22, 2023
ViktorHofer
reviewed
Oct 22, 2023
nohwnd
approved these changes
Oct 23, 2023
mthalman
approved these changes
Oct 23, 2023
|
Does these changes flow to the latest branches or does it need to be manually ported? |
|
@Evangelink @nohwnd - internal build is failing on one of the legs: https://dev.azure.com/dnceng/internal/_build/results?buildId=2298870&view=logs&j=22e02971-7ade-5002-875e-eef7feb6e7af&t=ddedce3e-d198-5a81-1ae5-9db245410658&l=217 Who can help investigate and fix this, so that we can get a good build that flows to 8.0 release? |
|
Looking. |
They don't automatically flow to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/source-build#3670
This fixes 2 source-build poison leaks: Microsoft.Extensions.DependencyModel.dll and Microsoft.Extensions.FileSystemGlobbing.dll that come from this repo. This was caused by missing package dependencies, which causes source-build to consume reference packages from SBRP repo.
The fix is a simple addition of explicit package dependencies, for versions used by VSTest repo. Source-build will automatically bump these package versions to latest, built in source-build.