Enable Trx logger in TPv2 #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Faizan2304
commented
Aug 11, 2016
Faizan2304
commented
- Add Trx Logger in Vsix.
- Pass output path to Trx logger. the path where the trx will get generated.
1) Add Trx Logger in Vsix. 2) Pass output path to Trx logger. the path where the trx will get generated.
Faizan2304
assigned codito, harshjain2, AbhitejJohn, singhsarab, Faizan2304 and saikrishnav
| @@ -6,11 +6,14 @@ namespace Microsoft.VisualStudio.TestPlatform.Common.Logging | |||
| using Microsoft.VisualStudio.TestPlatform.ObjectModel; | |||
| using Microsoft.VisualStudio.TestPlatform.ObjectModel.Client; | |||
| using Microsoft.VisualStudio.TestPlatform.ObjectModel.Logging; | |||
| using ObjectModel.Utilities; | |||
2) Added Test 3) Using buildable version of System.Diagnostics.TraceSource
| } | ||
|
|
||
| [TestMethod] | ||
| public void GetResultsDirectoryIsReadingFromRunsettings() |
There was a problem hiding this comment.
nitpick : Follow convention ShouldIf.
Suggestion : Change this method's name to GetResultsDirectoryShouldReadResultsDirectoryFromSettingsIfSpecified
There was a problem hiding this comment.
Fixed in next commit.
|
These changes has been merged to main branch through other Pull Request. Hence closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.