Fix setting of json serializer to ignore self referencing loop #796
Conversation
…ages in vstest\package folder
1) microsoft#706 2) microsoft#618 Fix: Don’t serialize the type if that have self-referencing loop
|
@Faizan2304, |
Faizan2304
changed the title
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
|
|
||
| [TestClass] | ||
| public class JsonDataSerializerTests |
There was a problem hiding this comment.
Should we have a test as part of TestResultSerializationTests? This will ensure the bug scenario is guarded.
There was a problem hiding this comment.
This will be the best way to write test for this bug but unfortunately we cant because we are not able to create an exception object which we can pass to TestRunCompleteEventArgs.
| DateTimeZoneHandling = DateTimeZoneHandling.Utc, | ||
| TypeNameHandling = TypeNameHandling.None, | ||
| ReferenceLoopHandling = ReferenceLoopHandling.Ignore | ||
| }); |
There was a problem hiding this comment.
Should we add same setting in other place?
There was a problem hiding this comment.
Make sure exception in serialize get logged in eqttrace log file.
There was a problem hiding this comment.
Fixed in next commit.
|
@dotnet-bot test Windows_NT / Debug Build |
Issue:
Fix:
Don’t serialize the type if that have self-referencing loop