Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinsert missing IDS_E_PATHINCOMPATIBLE string #331

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

Preecington
Copy link
Member

The error IDS_E_PATHINCOMPATIBLE was accidentally removed in #201 , which leads to a Error 0x7f: The specified procedure could not be found. output when specifying the -path arg with any other argument.

This PR restores the missing string (used here).

@Preecington Preecington requested a review from heaths January 25, 2025 00:00
@Preecington
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@heaths
Copy link
Member

heaths commented Jan 26, 2025

Ah, yes, this old problem. If you modify the file by any means other than VS (or was it only by VS? I forget now), it gets corrupted. I tried a few ways via .gitattributes to force it to use a certain encoding and/or line-ending (again, it's been a while so I don't quite remember the details) but was unsuccessful. That said, I've had a lot more experience since then geting all that stuff right because Go (which I do a lot of these days) requires LF for most of its files, and various other files I work with require certain encodings or line-endings.

If you want me to have another go at it, I can.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my comment, make sure this compiles and runs correctly. The line endings and/or encoding on this file is very finicky.

@Preecington
Copy link
Member Author

Just confirming this compiles locally and uses the new string:

image

@Preecington Preecington merged commit f1ecd08 into main Jan 27, 2025
2 checks passed
@Preecington Preecington deleted the dev/rpreece/missing-path-rc-string branch January 27, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants