Support detection of legacy VS products #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issues #24
|
@heaths, |
|
✅ Build vswhere 1.0.49+g1c98f107f3 completed (commit 1c98f107f3 by @heaths) |
et13
approved these changes
Mar 10, 2017
| using namespace std; | ||
|
|
||
| template <class T> | ||
| inline HRESULT NotImplemented(_In_ T* p) |
There was a problem hiding this comment.
Maybe name this NotFound? My initial reaction when reading this was that it would return E_NOTIMPL
There was a problem hiding this comment.
That was my initial thought as well, but the method is to indicate its not really implemented while the convention is to return E_NOTFOUND if the property wasn't defined (at least for the original interfaces).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issues #24