Avoid emitting enum members with emtpy names by throwing an exeption.…

… Fix the json that caused the empty enum member. Fixes #360
microsoft · Mar 16, 2021 · 94522b0 · 94522b0
1 parent c3b4b04
commit 94522b0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/generation/scraper/manualEnums.json b/generation/scraper/manualEnums.json
@@ -868,7 +868,7 @@
  },
  {
  "name": "ASN_SEQUENCE",
- "value": "(ASN_UNIVERSAL | ASN_CONSTRUCTOR | 0x10);"
+ "value": "(ASN_UNIVERSAL | ASN_CONSTRUCTOR | 0x10)"
  },
  {
  "name": "ASN_IPADDRESS",

diff --git a/sources/ClangSharpSourceToWinmd/ClangSharpSourceWinmdGenerator.cs b/sources/ClangSharpSourceToWinmd/ClangSharpSourceWinmdGenerator.cs
@@ -1297,9 +1297,15 @@ private void WriteEnumMembers(EnumDeclarationSyntax node)
 
  EncodeTypeSymbol(type, signatureEncoder);
 
+ var memberName = member.Identifier.Text;
+ if (string.IsNullOrEmpty(memberName))
+ {
+ throw new InvalidOperationException($"Enum {node.Identifier.Text} has a member with no name.");
+ }
+
  var fieldDefinitionHandle = metadataBuilder.AddFieldDefinition(
  enumFieldAttributes,
- metadataBuilder.GetOrAddString(member.Identifier.Text),
+ metadataBuilder.GetOrAddString(memberName),
  metadataBuilder.GetOrAddBlob(fieldSignature));
 
  if (symbol.HasConstantValue)