Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attribute on IPropertyStoreCapabilities::IsPropertyWritable #1942

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Add attribute on IPropertyStoreCapabilities::IsPropertyWritable #1942

merged 2 commits into from
Jul 8, 2024

Conversation

riverar
Copy link
Collaborator

@riverar riverar commented Jul 5, 2024 •
edited
Loading

Fixes: #1941

Adds CanReturnMultipleSuccessValues to IPropertyStoreCapabilities::IsPropertyWritable method. This method can return either S_OK or S_FALSE. Also removes the optional Attribute suffix on a few entries as cleanup.

AArnott
AArnott previously approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mikebattista
mikebattista requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@mikebattista mikebattista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the "-Attribute" suffix here and we don't use it elsewhere in this file. Please remove it for consistency.

@riverar
Copy link
Collaborator Author

riverar commented Jul 8, 2024

Oh I cut/pasted it from earlier in the file (GetMessage). Will fix.

@riverar riverar requested a review from mikebattista July 8, 2024 16:16
mikebattista
mikebattista approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@mikebattista mikebattista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@mikebattista mikebattista merged commit e8629a2 into main Jul 8, 2024
4 of 6 checks passed
@mikebattista mikebattista deleted the rafael/ipropertystorecapabilities branch July 8, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikebattista mikebattista mikebattista approved these changes

@AArnott AArnott AArnott left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IPropertyStoreCapabilities has no way to return its value
3 participants
@riverar @AArnott @mikebattista