Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map SECURITY_STATUS to HRESULT #832

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Map SECURITY_STATUS to HRESULT #832

merged 1 commit into from
Mar 14, 2022

Conversation

riverar
Copy link
Collaborator

@riverar riverar commented Mar 13, 2022

Maps SECURITY_STATUS native type name to HRESULT. Previously, the type lookup for SECURITY_STATUS would fail resulting in an int output.

SEC_x_xxxx constants were already mapped to HRESULT constants and live in Windows.Win32.Foundation today.

Fixes: #603

Metadata diff

Windows.Win32.Networking.HttpServer.HTTP_REQUEST_AUTH_INFO.SecStatus...System.Int32 => Windows.Win32.Foundation.HRESULT
Windows.Win32.Security.Authentication.Identity.SEC_GET_KEY_FN.Invoke : Status...Int32* => HRESULT*
Windows.Win32.Security.Authentication.Identity.ACQUIRE_CREDENTIALS_HANDLE_FN_W.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.ACQUIRE_CREDENTIALS_HANDLE_FN_A.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.FREE_CREDENTIALS_HANDLE_FN.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.ADD_CREDENTIALS_FN_W.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.ADD_CREDENTIALS_FN_A.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.CHANGE_PASSWORD_FN_W.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.CHANGE_PASSWORD_FN_A.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.INITIALIZE_SECURITY_CONTEXT_FN_W.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.INITIALIZE_SECURITY_CONTEXT_FN_A.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.ACCEPT_SECURITY_CONTEXT_FN.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.COMPLETE_AUTH_TOKEN_FN.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.IMPERSONATE_SECURITY_CONTEXT_FN.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.REVERT_SECURITY_CONTEXT_FN.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.QUERY_SECURITY_CONTEXT_TOKEN_FN.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.DELETE_SECURITY_CONTEXT_FN.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.APPLY_CONTROL_TOKEN_FN.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.QUERY_CONTEXT_ATTRIBUTES_FN_W.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.QUERY_CONTEXT_ATTRIBUTES_EX_FN_W.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.QUERY_CONTEXT_ATTRIBUTES_FN_A.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.QUERY_CONTEXT_ATTRIBUTES_EX_FN_A.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.SET_CONTEXT_ATTRIBUTES_FN_W.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.SET_CONTEXT_ATTRIBUTES_FN_A.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.QUERY_CREDENTIALS_ATTRIBUTES_FN_W.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.QUERY_CREDENTIALS_ATTRIBUTES_EX_FN_W.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.QUERY_CREDENTIALS_ATTRIBUTES_FN_A.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.QUERY_CREDENTIALS_ATTRIBUTES_EX_FN_A.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.SET_CREDENTIALS_ATTRIBUTES_FN_W.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.SET_CREDENTIALS_ATTRIBUTES_FN_A.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.FREE_CONTEXT_BUFFER_FN.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.MAKE_SIGNATURE_FN.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.VERIFY_SIGNATURE_FN.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.ENCRYPT_MESSAGE_FN.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.DECRYPT_MESSAGE_FN.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.ENUMERATE_SECURITY_PACKAGES_FN_W.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.ENUMERATE_SECURITY_PACKAGES_FN_A.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.QUERY_SECURITY_PACKAGE_INFO_FN_W.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.QUERY_SECURITY_PACKAGE_INFO_FN_A.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.EXPORT_SECURITY_CONTEXT_FN.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.IMPORT_SECURITY_CONTEXT_FN_W.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.IMPORT_SECURITY_CONTEXT_FN_A.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.SslGetServerIdentityFn.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.SslGetExtensionsFn.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.PFNCryptStreamOutputCallback.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.PFNCryptStreamOutputCallbackEx.Invoke : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptOpenStorageProvider : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptEnumAlgorithms : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptIsAlgSupported : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptEnumKeys : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptEnumStorageProviders : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptFreeBuffer : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptOpenKey : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptCreatePersistedKey : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptGetProperty : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptSetProperty : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptFinalizeKey : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptEncrypt : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptDecrypt : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptImportKey : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptExportKey : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptSignHash : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptVerifySignature : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptDeleteKey : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptFreeObject : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptTranslateHandle : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptNotifyChangeKey : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptSecretAgreement : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptDeriveKey : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptKeyDerivation : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptCreateClaim : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptVerifyClaim : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptRegisterProtectionDescriptorName : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptQueryProtectionDescriptorName : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptCreateProtectionDescriptor : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptCloseProtectionDescriptor : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptGetProtectionDescriptorInfo : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptProtectSecret : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptUnprotectSecret : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptStreamOpenToProtect : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptStreamOpenToUnprotect : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptStreamOpenToUnprotectEx : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptStreamUpdate : return...Int32 => HRESULT
Windows.Win32.Security.Cryptography.Apis.NCryptStreamClose : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.AcquireCredentialsHandleW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.AcquireCredentialsHandleA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.FreeCredentialsHandle : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.AddCredentialsW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.AddCredentialsA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.ChangeAccountPasswordW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.ChangeAccountPasswordA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.InitializeSecurityContextW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.InitializeSecurityContextA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.AcceptSecurityContext : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.CompleteAuthToken : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.ImpersonateSecurityContext : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.RevertSecurityContext : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.QuerySecurityContextToken : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.DeleteSecurityContext : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.ApplyControlToken : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.QueryContextAttributesW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.QueryContextAttributesExW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.QueryContextAttributesA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.QueryContextAttributesExA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.SetContextAttributesW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.SetContextAttributesA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.QueryCredentialsAttributesW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.QueryCredentialsAttributesExW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.QueryCredentialsAttributesA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.QueryCredentialsAttributesExA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.SetCredentialsAttributesW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.SetCredentialsAttributesA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.FreeContextBuffer : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.MakeSignature : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.VerifySignature : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.EncryptMessage : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.DecryptMessage : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.EnumerateSecurityPackagesW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.EnumerateSecurityPackagesA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.QuerySecurityPackageInfoW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.QuerySecurityPackageInfoA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.ExportSecurityContext : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.ImportSecurityContextW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.ImportSecurityContextA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.SaslEnumerateProfilesA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.SaslEnumerateProfilesW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.SaslGetProfilePackageA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.AddSecurityPackageW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.DeleteSecurityPackageA : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.DeleteSecurityPackageW : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.SslGetServerIdentity : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.SslGetExtensions : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.TokenBindingGenerateBinding : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.TokenBindingGenerateMessage : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.TokenBindingVerifyMessage : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.TokenBindingGetKeyTypesClient : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.TokenBindingGetKeyTypesServer : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.TokenBindingDeleteBinding : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.TokenBindingDeleteAllBindings : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.TokenBindingGenerateID : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.TokenBindingGenerateIDForUri : return...Int32 => HRESULT
Windows.Win32.Security.Authentication.Identity.Apis.TokenBindingGetHighestSupportedVersion : return...Int32 => HRESULT

@mikebattista mikebattista merged commit 9cd551c into microsoft:master Mar 14, 2022
@riverar riverar deleted the rafael/security_status branch March 14, 2022 19:35
@kennykerr
Copy link
Contributor

@jonwis do you know whether all uses of SECURITY_STATUS in the Windows API are now just HRESULTs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikebattista mikebattista mikebattista approved these changes

@sotteson1 sotteson1 Awaiting requested review from sotteson1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to use HRESULT with functions returning i32
3 participants
@riverar @kennykerr @mikebattista