Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: pin LLVM version in pipelines #175

Merged
merged 1 commit into from
Jun 18, 2024
Merged

ci: pin LLVM version in pipelines #175

merged 1 commit into from
Jun 18, 2024

Conversation

wmmc88
Copy link
Collaborator

@wmmc88 wmmc88 commented Jun 15, 2024 •
edited
Loading

As documented in #115 , LLVM 18 is bugged for arm64 targets.

This PR:

  • adds an additional CI matrix entry to test on specific LLVM versions instead of using whatever version is in the github windows runner image
    • currently only testing on latest LLVM 17
  • switches all winget commands to use the new winget powershell module so its easier to parse output

@wmmc88 wmmc88 force-pushed the fix-llvm-version branch 9 times, most recently from ba2a7d0 to 21d3de0 Compare June 15, 2024 06:53
@wmmc88 wmmc88 force-pushed the fix-llvm-version branch from 21d3de0 to d81b3d9 Compare June 15, 2024 07:15
@wmmc88 wmmc88 marked this pull request as ready for review June 15, 2024 19:48
@wmmc88 wmmc88 requested a review from a team June 15, 2024 19:53
@wmmc88 wmmc88 mentioned this pull request Jun 15, 2024
Merged
@ayodejiige
Copy link

See comments in microsoft/Windows-rust-driver-sample#19

ayodejiige
ayodejiige approved these changes Jun 18, 2024
View reviewed changes
Copy link

@ayodejiige ayodejiige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some minor comments

@wmmc88 wmmc88 enabled auto-merge June 18, 2024 16:44
@wmmc88 wmmc88 disabled auto-merge June 18, 2024 17:06
@wmmc88 wmmc88 added this pull request to the merge queue Jun 18, 2024
Merged via the queue into microsoft:main with commit 2730981 Jun 18, 2024
49 checks passed
@wmmc88 wmmc88 deleted the fix-llvm-version branch June 18, 2024 18:35
@wmmc88 wmmc88 mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzamust hamzamust hamzamust approved these changes

@ayodejiige ayodejiige ayodejiige approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wmmc88 @ayodejiige @hamzamust