Fix BOOLEAN parameter binding (#2635)

microsoft · Aug 28, 2023 · 101467c · 101467c
1 parent 0b86626
commit 101467c
Show file tree

Hide file tree

Showing 5 changed files with 46 additions and 2 deletions.
diff --git a/crates/libs/bindgen/src/rust/extensions/mod/Win32/Foundation/BOOLEAN.rs b/crates/libs/bindgen/src/rust/extensions/mod/Win32/Foundation/BOOLEAN.rs
@@ -66,3 +66,8 @@ impl ::core::ops::Not for BOOLEAN {
         }
     }
 }
+impl ::windows_core::IntoParam<BOOLEAN> for bool {
+    fn into_param(self) -> ::windows_core::Param<BOOLEAN> {
+        ::windows_core::Param::Owned(self.into())
+    }
+}
diff --git a/crates/libs/windows/src/Windows/Win32/Foundation/mod.rs b/crates/libs/windows/src/Windows/Win32/Foundation/mod.rs
@@ -21677,6 +21677,11 @@ impl ::core::ops::Not for BOOLEAN {
         }
     }
 }
+impl ::windows_core::IntoParam<BOOLEAN> for bool {
+    fn into_param(self) -> ::windows_core::Param<BOOLEAN> {
+        ::windows_core::Param::Owned(self.into())
+    }
+}
 impl NTSTATUS {
     #[inline]
     pub const fn is_ok(self) -> bool {

diff --git a/crates/tests/extensions/Cargo.toml b/crates/tests/extensions/Cargo.toml
@@ -9,4 +9,8 @@ path = "../../libs/windows"
 features = [
     "Win32_Foundation",
     "Win32_Security_Cryptography",   
+    "Win32_NetworkManagement_IpHelper",
+    "Win32_NetworkManagement_Ndis",
+    "Win32_Networking_WinSock",
+    "Win32_System_Threading",
 ]
diff --git a/crates/tests/extensions/tests/bool32.rs b/crates/tests/extensions/tests/bool32.rs
@@ -1,4 +1,4 @@
-use windows::Win32::Foundation::*;
+use windows::{Win32::Foundation::*, Win32::System::Threading::*};
 
 #[test]
 fn test() {
@@ -21,3 +21,12 @@ fn test() {
     let error = result.unwrap_err();
     assert_eq!(error.code(), E_ACCESSDENIED);
 }
+
+#[test]
+#[ignore]
+fn no_run() {
+    unsafe {
+        _ = CreateEventA(None, false, true, None);
+        _ = CreateEventA(None, BOOL(0), BOOL(1), None);
+    }
+}
diff --git a/crates/tests/extensions/tests/boolean.rs b/crates/tests/extensions/tests/boolean.rs
@@ -1,4 +1,4 @@
-use windows::Win32::Foundation::*;
+use windows::{Win32::Foundation::*, Win32::NetworkManagement::IpHelper::*};
 
 #[test]
 fn test() {
@@ -21,3 +21,24 @@ fn test() {
     let error = result.unwrap_err();
     assert_eq!(error.code(), E_ACCESSDENIED);
 }
+
+#[test]
+#[ignore]
+fn no_run() {
+    unsafe {
+        _ = NotifyUnicastIpAddressChange(
+            Default::default(),
+            None,
+            None,
+            true,
+            std::ptr::null_mut(),
+        );
+        _ = NotifyUnicastIpAddressChange(
+            Default::default(),
+            None,
+            None,
+            BOOLEAN(1),
+            std::ptr::null_mut(),
+        );
+    }
+}