Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct compose offset in implement macro #1724

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Correct compose offset in implement macro #1724

merged 1 commit into from
Apr 28, 2022

Conversation

kennykerr
Copy link
Collaborator

This affects only Xaml - I have updated the Xaml sample to trigger the offset calculation.

Once authoring support is further along (#1094), we should add a composition test to the test_component to validate this as well.

@kennykerr kennykerr requested a review from riverar April 28, 2022 16:37
riverar
riverar approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@riverar riverar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@riverar riverar merged commit 4c0860b into master Apr 28, 2022
@riverar riverar deleted the compose branch April 28, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riverar riverar riverar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kennykerr @riverar