Support COM-style query signatures with unconventional parameter positions #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
changed the title
|
It looks great! |
|
Do you want to loosen up the type check on the ComOutPtr parameter? (Seems to be limited to void** right now.) That would let in trouble makers like: // Windows.Win32.Graphics.Direct2D.ID2D1Factory1
unsafe HRESULT GetEffectProperties([In][Const] Guid* effectId, [Out][ComOutPtr] ID2D1Properties* properties);
// Windows.Win32.UI.Shell.IHlinkBrowseContext
unsafe HRESULT Clone([In] IUnknown piunkOuter, [In][Const] Guid* riid, [Out][ComOutPtr] IUnknown* ppiunkObj); |
|
I think it might be better to fix those in metadata. That way we can confirm they are truly meant to be Case law: microsoft/win32metadata#446 |
rylev
reviewed
Jun 8, 2022
rylev
approved these changes
Jun 9, 2022
| } | ||
| _ => { | ||
| let name = self.param_name(param.def); | ||
| if let ArrayInfo::Fixed(fixed) = param.array_info { |
There was a problem hiding this comment.
Instead of the chained if let ArrayInfo and continue calls you can turn this all into a match expression.
There was a problem hiding this comment.
There seem to be quite a few such candidates. I can tackle these separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1354
@robmikh let me know what you think of the transformation of
ICompositionDrawingSurfaceInterop.