Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include nested dependencies in standalone code generation #2480

Merged
merged 6 commits into from
Apr 27, 2023

Conversation

Jake-Shadle
Copy link
Contributor

@Jake-Shadle Jake-Shadle commented Apr 27, 2023

This PR fixes 2 issues:

  • When emitting COM interfaces with standalone_sys the type aliases were not pub like everything else.
  • Nested types were not being crawled when gathering the types, which would result in fields in nested records that used types that were unique to them to not be emitted

Fixes: #2478
Fixes: #2479

@kennykerr
Copy link
Collaborator

Thanks for the fix! Just need to rerun cargo run -p tool_core to regenerate the internal bindings.

When emitting COM interfaces with standalone_sys the type aliases were not pub like everything else.

The trouble here is that this may introduce name collisions. I'm not opposed to changing it, but we'd need to be a bit more explicit in windows-core about how we refer to those bindings.

@Jake-Shadle
Copy link
Contributor Author

Oof, yah, that broke everything.

@kennykerr
Copy link
Collaborator

I can fix that up in a separate PR if you'd prefer. Let me know.

@Jake-Shadle
Copy link
Contributor Author

I just replaced the bindings::* with explicit exports, it's not pretty but works.

@kennykerr
Copy link
Collaborator

Sounds good - I can find a prettier solution separately.

@kennykerr kennykerr changed the title Fixup standalone Include nested dependencies in standalone code generation Apr 27, 2023
@kennykerr kennykerr merged commit 7c835e3 into microsoft:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants