Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immutable Event implementation #3198

Merged
merged 18 commits into from
Aug 16, 2024
Merged

Immutable Event implementation #3198

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2d7829a
use RwLock for interior mutability
lifers Aug 12, 2024
09a4de9
update tests to use non-mutable event
lifers Aug 12, 2024
0337f17
revert accidental change on Array::swap
lifers Aug 12, 2024
33d8896
use cast to *mut Array<T>
lifers Aug 13, 2024
db90add
use cast to *mut Array<T>
lifers Aug 13, 2024
48024c2
use cast to *mut Array<T>
lifers Aug 13, 2024
49509e8
Merge branch 'master' of https://github.com/lifers/windows-rs
lifers Aug 13, 2024
253a005
take &mut self to swap array
lifers Aug 13, 2024
b0df0b2
clippy lint disallowed mut_from_ref
lifers Aug 13, 2024
fdaeb15
impl Send and Sync for Event
lifers Aug 13, 2024
9e4a471
Replace `Array<T>` with Rust types
lifers Aug 15, 2024
9449391
construct Arc directly from iterator
lifers Aug 16, 2024
d987a51
Add `Default`, `Send`, and `Sync` trait
lifers Aug 16, 2024
520b595
drop old delegates after lock is released
lifers Aug 16, 2024
dff4499
Prefer more explicit drop order
lifers Aug 16, 2024
208e52f
Test for `Send` and `Sync`
lifers Aug 16, 2024
bf72954
formatting
lifers Aug 16, 2024
b0bc9b1
Take the guard as late as possible
lifers Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/libs/core/src/event.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ pub struct Event<T: Interface> {
delegates: UnsafeCell<Array<T>>,
}

unsafe impl<T: Interface> Send for Event<T> {}
unsafe impl<T: Interface> Sync for Event<T> {}
kennykerr marked this conversation as resolved.
Show resolved Hide resolved

impl<T: Interface> Default for Event<T> {
fn default() -> Self {
Self::new()
Expand Down