Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly document MSRV #894

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Explicitly document MSRV #894

merged 1 commit into from
Jun 22, 2021

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Jun 22, 2021

Somewhere along the way, we stopped tracking the minimum supported Rust version (MSRV). This adds it back to CI and adds a note about it in the FAQ.

New CI tests run in parallel and the new pass for the MSRV is faster than other tests we're doing so this does not slow down CI builds.

@rylev rylev requested a review from kennykerr June 22, 2021 10:56
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I wish there was a way to set this in the crate somehow to avoid the mysterious errors when older compilers are used by mistake.

@kennykerr kennykerr merged commit 45fb680 into master Jun 22, 2021
@kennykerr kennykerr deleted the msrv branch June 22, 2021 14:14
@rylev
Copy link
Contributor Author

rylev commented Jun 22, 2021

There will be, but it's not stable yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants