Restore dogfooding in XP #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roytam1
commented
Apr 9, 2018
roytam1
commented
- Downgrade VC project to VC2010
- Downgrade C/C++ syntax to VC2010
- Dynamic loading Wow64 functions
- Downgrade VC project to VC2010 - Downgrade C/C++ syntax to VC2010 - Dynamic loading Wow64 functions
|
|
cfrank-rv
reviewed
Apr 9, 2018
src/wfgoto.cpp
Outdated
| { | ||
| vector<PDNODE> * option = options_per_word.at(i); |
There was a problem hiding this comment.
Nit: follow code style for pointerAlignment
vector<PDNODE> *option = options_per_word.at(i);
|
I'm open to changes to the .c/.h sources which make this use case possible, but I will not downgrade the vcxproj file. You will need to create a separate one to compile with anything other than VS2015 and VS2017. |
|
Yeah, I agree with craigwi. We shouldn't downgrade to an older project file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.