-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore XP compatibility #59
Conversation
roytam1
commented
Apr 10, 2018
- Downgrade C/C++ syntax to VC2010
- Dynamic loading of Wow64 functions
- Create wrapper of RegGetValue
- Downgrade C/C++ syntax to VC2010 - Dynamic loading of Wow64 functions - Create wrapper of RegGetValue
I don't think this should be merged into master, it significantly holds back the rest of the codebase from using features in C++ that would increase safety and produce a faster better result all to support an unsupported operating system. |
I think that the goal of this project is more to bring winfile to newer systems, and to bring modern improvements to it. I, however, am also most interested in backporting these improvements to older platforms. But like @leeter, I think that this should be done on a separate branch/fork to avoid conflicts with the improvements/modernization goal, and cherry-pick what we bring in based on what will work on old platforms. |
We should combine efforts and use this on a separate retro branch, as others noted. See issue #3 That way that specific branch can be dedicated to work on as many legacy versions of Windows as possible. Perhaps we can call it Version 9.x |
You don't need to downgrade to VS2010, because you can still use VS2017 to compile XP applications. |
@Azarien because I want to dogfood in XP and VC2010 is last version working on XP. |
Should this PR be merged into the retro branch? Currently the solution in the retro branch is still using VS2015. Or do we want to use versions of visual studios that are older than 2010, such as VS2008 or VS2005. |
@NazmusLabs I don't know, and this is 2nd PR attempt which has vcxproj changes removed. |
@roytam1 yes, exactly. The idea is to those changes into the retro branch. That's why the branch was created. |
Has anyone tried the Win XP support in VS 2017? Perhaps that's a way to get an XP build? |
Still wondering... |
@craigwi this PR may need to be closed in favor of retro branch instead? |
OK; thanks for responding. |