Package type Dependency graph #1341

fzanollo · 2021-08-03T19:30:31Z

Contains:

Dependency graph data structure implementation and testing.
Automatic installation of package type dependencies during install, import and upgrade commands.
Will not manage or try to install any of the other types of dependencies (Windows Features, Windows Libraries, External).

Closes #1287

Microsoft Reviewers: Open in CodeFlow

… import

…nciesFlow

…dencyList; add Dependency to context data

…DpeendencyType

…es task divided, creates ValidateFlow

…DependencyList.dependencies private, code style

Co-authored-by: JohnMcPMS <johnmcp@microsoft.com>

…encies is now a WorkflowTask receiving resource string id

…w, move dependency related function to DependenciesFlow

azure-pipelines · 2021-10-11T23:02:57Z

Azure Pipelines successfully started running 1 pipeline(s).

… dependencyGraph

src/AppInstallerCLICore/Commands/UpgradeCommand.cpp

src/AppInstallerCLICore/Workflows/DependenciesFlow.cpp

src/AppInstallerCommonCore/Public/winget/ManifestCommon.h

src/AppInstallerCLITests/WorkFlow.cpp

src/AppInstallerCommonCore/Public/winget/ManifestCommon.h

src/AppInstallerRepositoryCore/Microsoft/Schema/1_3/Interface_1_3.cpp

… dependencyGraph

github-actions · 2021-10-19T17:33:41Z

@check-spelling-bot Report

Unrecognized words, please review:

Pacakages

To accept these unrecognized words as correct, run the following commands

... in a clone of the git@github.com:fzanollo/winget-cli.git repository
on the dependencyGraph branch:

update_files() {
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/946947204" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

github-actions · 2021-10-19T20:23:25Z

@check-spelling-bot Report

Unrecognized words, please review:

Attmpt
Pacakages

To accept these unrecognized words as correct, run the following commands

... in a clone of the git@github.com:fzanollo/winget-cli.git repository
on the dependencyGraph branch:

update_files() {
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/947076835" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

github-actions · 2021-10-20T03:03:25Z

@check-spelling-bot Report

Unrecognized words, please review:

Attmpt
Pacakages

To accept these unrecognized words as correct, run the following commands

... in a clone of the git@github.com:fzanollo/winget-cli.git repository
on the dependencyGraph branch:

update_files() {
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/947278873" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

github-actions · 2021-10-20T03:04:57Z

@check-spelling-bot Report

Unrecognized words, please review:

Attmpt
Pacakages

Previously acknowledged words that are now absent

activatable mytool

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:fzanollo/winget-cli.git repository
on the dependencyGraph branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/947279517" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

into dependencyGraph

hackean-msft · 2021-10-20T16:29:19Z

/azp run

azure-pipelines · 2021-10-20T16:29:31Z

Azure Pipelines successfully started running 1 pipeline(s).

… dependencyGraph

github-actions · 2021-10-22T17:19:14Z

@check-spelling-bot Report

Unrecognized words, please review:

Dependecy
Preffered

Previously acknowledged words that are now absent

activatable Globals mytool Workflows

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:fzanollo/winget-cli.git repository
on the dependencyGraph branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/949823411" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

github-actions · 2021-10-23T03:03:48Z

@check-spelling-bot Report

Unrecognized words, please review:

Preffered

Previously acknowledged words that are now absent

activatable Globals mytool Workflows

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:fzanollo/winget-cli.git repository
on the dependencyGraph branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/950046927" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

hackean-msft · 2021-10-23T16:54:45Z

/azp run

azure-pipelines · 2021-10-23T16:54:56Z

Azure Pipelines successfully started running 1 pipeline(s).

hackean-msft · 2021-10-26T18:03:39Z

/azp run

azure-pipelines · 2021-10-26T18:03:54Z

Azure Pipelines successfully started running 1 pipeline(s).

fzanollo and others added 30 commits June 4, 2021 18:16

first tests for show depenencies feature

9c72b02

show dependencies feature for show, install, need to change message

0a81ec5

showflow output changed

b416985

install commands shows dependencies as in specs

c848824

tests for informing dependencies on commands: show, install, upgrade,…

688cbe5

… import

refactor install flow

7b488f1

change import command from install flow (install multiple)

c8d02ea

import shows all dependencies together

72fd209

show dependencies for validate and uninstall

d6d0c53

tests for validate and uninstall

d3063f2

create show dependencies exp feature

9d05f6f

test for validate command

e3ccc8e

put functionality under experimental feature check

44fe9e2

enable show dep experimental feature on unit test cases

a69b930

change experimental feature name

8bb3aa1

remove info stream characters on testcase

9737ae1

move check for exp feature inside report function, create new Depende…

49c7fea

…nciesFlow

DependenciesFlow header and cpp inside Workflow

74d29ff

�change representation of Dependency, create DependencyType and Depen…

b7590c3

…dencyList; add Dependency to context data

dependencies context data is of type DependencyList (not optional)

b04225a

fix spelling errors

2a620d8

ApplyTo function, can receibe a lambda function to apply on specific …

40e05b4

…DpeendencyType

localize user strings, code style changes, validate report dependenci…

d8c411f

…es task divided, creates ValidateFlow

change uninstall flow (gets dependencies from package version), make …

9f3961a

…DependencyList.dependencies private, code style

add missing report dep on upgrade

1c6347f

Update src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw

c785b14

Co-authored-by: JohnMcPMS <johnmcp@microsoft.com>

compare id with ICU case insensitive

0a31f79

move dependencies related functions to DependenciesFlow, ReportDepend…

af7b09c

…encies is now a WorkflowTask receiving resource string id

TODO to get dependencies on uninstall context, remove testcase for no…

8fce81d

…w, move dependency related function to DependenciesFlow

wfIds not temporary

af036e4

Merge branch 'master' of https://github.com/microsoft/winget-cli into…

68e9c53

… dependencyGraph

JohnMcPMS requested changes Oct 15, 2021

View reviewed changes

ghost added the Needs-Author-Feedback Issue needs attention from issue or PR author label Oct 15, 2021

Akinwale Alagbe added 2 commits October 16, 2021 10:12

Merge branch 'master' of https://github.com/microsoft/winget-cli into…

212ffa6

… dependencyGraph

Addressed pr comments.

4d4af06

Addressed PR comments 2

681d88c

Code cleanup

1210a5f

Merge branch 'master' into dependencyGraph

5b6a4fb

Akinwale Alagbe added 2 commits October 20, 2021 09:26

Fixed spell check error

e2e5f61

Merge branch 'dependencyGraph' of https://github.com/fzanollo/winget-cli

ee9ea0b

into dependencyGraph

Akinwale Alagbe added 2 commits October 20, 2021 15:34

Merge branch 'master' of https://github.com/microsoft/winget-cli into…

160c4c6

… dependencyGraph

Refactored DependencyGraph

ad46ffe

Fixed typos

2a247bd

Code refactor and typo fix

b5788b9

JohnMcPMS approved these changes Oct 25, 2021

View reviewed changes

Pulled and fixed merge conficts

d7a0391

hackean-msft merged commit bb67e38 into microsoft:master Oct 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Package type Dependency graph #1341

Package type Dependency graph #1341

fzanollo commented Aug 3, 2021 •

edited by ghost

Loading

azure-pipelines bot commented Oct 11, 2021

github-actions bot commented Oct 19, 2021 •

edited

Loading

github-actions bot commented Oct 19, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021 •

edited

Loading

hackean-msft commented Oct 20, 2021

azure-pipelines bot commented Oct 20, 2021

github-actions bot commented Oct 22, 2021 •

edited

Loading

github-actions bot commented Oct 23, 2021 •

edited

Loading

hackean-msft commented Oct 23, 2021

azure-pipelines bot commented Oct 23, 2021

hackean-msft commented Oct 26, 2021

azure-pipelines bot commented Oct 26, 2021

Package type Dependency graph #1341

Package type Dependency graph #1341

Conversation

fzanollo commented Aug 3, 2021 • edited by ghost Loading

Microsoft Reviewers: Open in CodeFlow

azure-pipelines bot commented Oct 11, 2021

github-actions bot commented Oct 19, 2021 • edited Loading

@check-spelling-bot Report

Unrecognized words, please review:

github-actions bot commented Oct 19, 2021 • edited Loading

@check-spelling-bot Report

Unrecognized words, please review:

github-actions bot commented Oct 20, 2021 • edited Loading

@check-spelling-bot Report

Unrecognized words, please review:

github-actions bot commented Oct 20, 2021 • edited Loading

@check-spelling-bot Report

Unrecognized words, please review:

hackean-msft commented Oct 20, 2021

azure-pipelines bot commented Oct 20, 2021

github-actions bot commented Oct 22, 2021 • edited Loading

@check-spelling-bot Report

Unrecognized words, please review:

github-actions bot commented Oct 23, 2021 • edited Loading

@check-spelling-bot Report

Unrecognized words, please review:

hackean-msft commented Oct 23, 2021

azure-pipelines bot commented Oct 23, 2021

hackean-msft commented Oct 26, 2021

azure-pipelines bot commented Oct 26, 2021

fzanollo commented Aug 3, 2021 •

edited by ghost

Loading

github-actions bot commented Oct 19, 2021 •

edited

Loading

github-actions bot commented Oct 19, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021 •

edited

Loading

github-actions bot commented Oct 22, 2021 •

edited

Loading

github-actions bot commented Oct 23, 2021 •

edited

Loading