-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expected installer return codes #1421
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sure we have the full set of cases covered; "reboot required" being missing suggests that we have some to get still.
Also, the arguably more important part of this change is having a healthy set of default values per installer type and thorough thought put into how those would be overridden by the manifest. Requiring every MSI to output the fairly standardized set of values is not helpful.
This also plays into my comment on MSIX, as we can normalize the HRESULT returns from deployment into the set of values that we have here to make all package types easier to work with in a uniform fashion.
src/AppInstallerCommonCore/Public/AppInstallerLanguageUtilities.h
Outdated
Show resolved
Hide resolved
Updated with default values per installer type.
|
src/AppInstallerRepositoryCore/Rest/Schema/1_1/Json/ManifestDeserializer_1_1.cpp
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding expected return codes for installer. Expected return codes are translated to specific HResults when found and show a custom error message.
Not in this PR: Changes for REST sources
Microsoft Reviewers: Open in CodeFlow