Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks to spelling to fix issues #1480

Merged
merged 1 commit into from
Sep 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/actions/spelling/allow.txt
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ authz
autocomplete
auxdata
azureedge
bcp
bcp47
bcrypt
binver
Bitmask
Expand All @@ -51,6 +49,7 @@ cla
CLSCTX
cmake
cmdlet
cmdlets
cmp
CNG
cnt
Expand Down
17 changes: 14 additions & 3 deletions .github/actions/spelling/expect.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Aysnc
azurewebsites
badbit
Baz
bcp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually fits in allow.txt since there's api we use with bcp as partial of the api name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was seeing strange behavior in the allow file when we had bcp47. I don't think spelling likes having numbers in words. Do you think I should move this back to allow?

Beigi
bfd
bght
Expand Down Expand Up @@ -78,6 +79,7 @@ contractversion
count'th
countof
countryregion
convertto
createmanifestmetadata
cstdint
ctc
Expand All @@ -92,6 +94,8 @@ dirs
diskfull
dnld
Dobbeleer
doctordns
DSL
dustojnikhummer
dvinns
dw
Expand All @@ -104,6 +108,7 @@ EQU
ERANGE
errno
ESRB
etail
etest
execustom
EXEHASH
Expand All @@ -130,7 +135,7 @@ GES
GESMBH
GHS
gity
Globals
globals
Google
helplib
helplibrary
Expand Down Expand Up @@ -171,7 +176,9 @@ itr
IVector
IWeb
IZone
Jaifroid
jdk
JDKs
jfearn
JObject
jp
Expand Down Expand Up @@ -209,6 +216,7 @@ megamorf
memcpy
middleware
midl
mikefrobbins
minexample
minschema
missingdependency
Expand All @@ -233,6 +241,7 @@ mysilentwithprogress
mytool
netlify
Newtonsoft
Nieto
NOEXPAND
nonetwork
normer
Expand All @@ -259,6 +268,7 @@ pkgmgr
pkindex
PMS
positionals
powershellexplained
powertoys
pri
processthreads
Expand Down Expand Up @@ -378,13 +388,14 @@ winreg
withstarts
wn
Workflows
WSL
wsl
wsv
wto
wwinmain
WZDNCRFJ
xbox
XPLATSTR
xsi
yamlcreateps
Zanollo
zy
zy