Add option to check fields requiring verified publisher in manifest p… #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
approved these changes
Sep 24, 2021
| Manifest& manifest, | ||
| const ManifestVer& manifestVersion, | ||
| bool fullValidation, | ||
| bool errorOnVerifiedPublisherFields) |
There was a problem hiding this comment.
For the long term it probably makes more sense to pass the ManifestValidateOption around rather than individual bools. That would also mean moving it into the Manifest namespace rather than being in YAML (which makes sense really).
There was a problem hiding this comment.
When I wrote that I thought that it was a struct; I still stand by it being easier to update though. You only need to add a new helper function (if that even) to call WI_IsFlagSet and you have a new control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Extend manifest validation option to support validating fields requiring verified publishers.
Validation
Added tests.
Microsoft Reviewers: Open in CodeFlow