Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add product code and PFN to enable existing searches #1677

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Nov 4, 2021

Change

Add ProductCode and PackageFamilyName values to enum to enable the existing search capabilities through COM.

Also updates the sample caller to have the packageQuery capability as I found that it did not during some manual testing.

Validation

Manual update to sample app to try it out.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner November 4, 2021 23:59
@@ -26,6 +26,7 @@
</Applications>
<Capabilities>
<Capability Name="internetClient" />
<rescap:Capability Name="packageQuery" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packageQuery

packageManagement should already include packageQuery in semantics, did you find places that only work with packageQuery but not packageManagement? If yes, we may need to fix those.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it looks like the code is doing that and I was just seeing the failure to directly find packageQuery while debugging. I can revert this and update the code to not log a failure here.

Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JohnMcPMS JohnMcPMS merged commit 5c5826e into microsoft:master Nov 5, 2021
@JohnMcPMS JohnMcPMS deleted the srscom branch November 5, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants