Check for symlink creation privilege for portable install #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Issue-Bug
Trenly
reviewed
Jul 26, 2022
JohnMcPMS
requested changes
Jul 26, 2022
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
JohnMcPMS
approved these changes
Jul 26, 2022
|
Why does this test for running as admin? AFAIK all that is required to create symlinks is having SeCreateSymbolicLinkPrivilege, not being an administrator. |
|
@jantari it requires either the user to be in administrator mode or to have developer mode enabled on Windows. A normal user account otherwise can't create symbolic links. It was a very late breaking issue we ran into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2364
Related to #2368
Checks if developer mode is enabled for portable install. If developer mode is not enabled, requires command to be running as admin. Additionally, a link to the related GitHub issue is displayed to the user.
Tests:
Microsoft Reviewers: Open in CodeFlow