Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect scope in installer metadata #2415

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Aug 3, 2022

Change

Include the installed scope during metadata collection. This uses the current detection method, which is "HKLM or HKCU?"

When there us a mismatch, the value will be explicitly set to Unknown.

Validation

New unit tests added, mostly for the mismatch cases.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner August 3, 2022 23:55
Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JohnMcPMS JohnMcPMS merged commit 0ebb5b9 into microsoft:master Aug 5, 2022
@JohnMcPMS JohnMcPMS deleted the scope-collect branch August 5, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants