Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema draft for WinGet configure #2851

Merged
merged 5 commits into from
Mar 15, 2023
Merged

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Jan 13, 2023

Related to: #2845

This is a rough draft of the proposed schema that outlines the fields that could be utilized to provide the information necessary for WinGet configure.

Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner January 13, 2023 19:38
@github-actions

This comment has been minimized.

@denelon
Copy link
Contributor

denelon commented Jan 13, 2023

@SteveL-MSFT based on some of our internal proposals, @ryfu-msft drafted this JSON schema. We believe this will ultimately best live in a PowerShell DSC GitHub repository in the future, but we would like to iterate here. We will create an https://aka.ms link for the schema so preview users can also try this out, and when the time is right to move this to a PowerShell repository, we can create the PR and adjust the https://aka.ms link.

I've added you as a reviewer since it should follow any prior art with respect to PowerShell naming and idioms.

@ghost ghost added the Needs-Author-Feedback Issue needs attention from issue or PR author label Jan 13, 2023
@ghost ghost removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Jan 19, 2023
@github-actions

This comment has been minimized.

@ryfu-msft
Copy link
Contributor Author

This schema is not final and we will continue to iterate on this version for now. Planning to check this in so that people can use it as a reference for building their own configuration yamls.

@ryfu-msft ryfu-msft dismissed JohnMcPMS’s stale review March 15, 2023 17:53

Checking this in so we can have a basic schema for reference. I removed the unimplemented/unplanned fields and will iterate on this schema as needed.

@ryfu-msft ryfu-msft merged commit e6c9359 into microsoft:master Mar 15, 2023
@ryfu-msft ryfu-msft deleted the configSchema branch March 15, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants