-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Policy for controlling sources #841
Conversation
src/AppInstallerRepositoryCore/Public/AppInstallerRepositorySource.h
Outdated
Show resolved
Hide resolved
const ValueList::ValueRef& ValueList::const_iterator::operator*() const | ||
{ | ||
return m_value.value(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that it matters much for the general use case, but I would err toward making the caller keep the value while they wanted it rather than the iterator getting the value while iterating. If I wanted to skip ahead for some reason this way reads every value anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the assumption that changes to resolve the test failures will be minor.
Two tests failed. One was because in one test for failure adding a disabled default source I needed to add the Type in the test to fit the Arg+Type matching (where I only used the Arg before). The other was because I had a test for the Data+Identifier check after adding the source; I removed the test since that check was removed. |
Adding enforcement of Group Policies for additional required sources and allowed sources. This change includes:
GroupPolicyException
type for reporting errors.source export
command to produce the JSON strings used in the policies.Still pending for Group Policies:
Microsoft Reviewers: Open in CodeFlow