Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty list fields from the manifest #563

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Remove empty list fields from the manifest #563

merged 1 commit into from
Dec 10, 2024

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Nov 30, 2024 •
edited
Loading

This PR makes it so that empty list fields like Tags: [], Agreements: [] are removed from the manifest before it's serialized.

Validation

Updated unit tests to cover empty lists. For a manual example try:

wingetcreate update VeyonSolutions.Veyon --urls https://github.com/veyon/veyon/releases/download/v4.9.1/veyon-4.9.1.0-win32-setup.exe https://github.com/veyon/veyon/releases/download/v4.9.1/veyon-4.9.1.0-win64-setup.exe --version 2.0.0

and see that Tags: [] is not present in the manifest with this change

Microsoft Reviewers: Open in CodeFlow

@mdanish-kh mdanish-kh requested a review from a team as a code owner November 30, 2024 09:57
@mdanish-kh mdanish-kh requested review from yao-msft and ryfu-msft and removed request for a team November 30, 2024 09:57
ryfu-msft
ryfu-msft approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@ryfu-msft ryfu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ryfu-msft
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdanish-kh
Copy link
Contributor Author

@ryfu-msft Looks like it's the same error that you were tackling in

@ryfu-msft ryfu-msft merged commit 94c5d21 into microsoft:main Dec 10, 2024
3 of 5 checks passed
@mdanish-kh mdanish-kh deleted the empty-lists branch December 10, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryfu-msft ryfu-msft ryfu-msft approved these changes

@yao-msft yao-msft Awaiting requested review from yao-msft yao-msft is a code owner automatically assigned from microsoft/oca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdanish-kh @ryfu-msft