Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Request]: ASRock.AppShop #160709

Open
4 of 6 tasks
RokeJulianLockhart opened this issue Jun 29, 2024 · 12 comments
Open
4 of 6 tasks

[Package Request]: ASRock.AppShop #160709

RokeJulianLockhart opened this issue Jun 29, 2024 · 12 comments
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Hardware Specific hardware is required to install or validate this package

Comments

@RokeJulianLockhart
Copy link
Contributor

RokeJulianLockhart commented Jun 29, 2024

How can we help?

I would like someone else to build the manifest.

Please read and ensure the following

  • The installer meets the above requirements

Please provide the following information

Package Requested

  • I would like someone else to build the manifest.
  • I would like help, so I can submit the manifest.
  • I have performed a search and couldn't find this package.
  • I have checked that the installer for this package is not a standalone or portable executable or a .zip file
  • I think there is a new version available, and I have provided the URL.

Please provide the following information

Download Page URI https://www.asrock.com/feature/appshop/#:~:text=Size%20%09Description-,Download,-4.26MB%20%09APP%20Shop
Publisher ASRock
Package Name ASRock.AppShop
Description
ASRock APP Shop is an all-in-one utility designed for system update and software downloading.
Package Version 2.0.0.4
Installer URI https://download.asrock.com/Utility/Others/APPShop%28v2.0.0.4%29.zip from https://www.asrock.com/feature/appshop/dl.asp
@RokeJulianLockhart RokeJulianLockhart added Help-Wanted This is a good candidate work item from the community. Package-Request This is a request for a package (new or updated version) labels Jun 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jun 29, 2024
@Dragon1573
Copy link
Contributor

Really weird ...

10:42:18 D:\...\winget-pkgs  [issues/160709 +1 ~0 -0 !] 48.044s pwsh> sudo winget install -m .\manifests\a\ASRock\AppShop\2.0.0.4\
已找到 APP Shop [ASRock.AppShop] 版本 2.0.0.4
此应用程序由其所有者授权给你。
Microsoft 对第三方程序包概不负责,也不向第三方程序包授予任何许可证。
正在下载 https://download.asrock.com/Utility/Others/APPShop(v2.0.0.4).zip
  ██████████████████████████████  4.26 MB / 4.26 MB
已成功验证安装程序哈希
正在提取存档...
已成功提取存档
正在启动程序包安装...
已成功安装

image image

@RokeJulianLockhart
Copy link
Contributor Author

RokeJulianLockhart commented Jun 30, 2024

#160709 (comment)

@Dragon1573, are you using an ASRock motherboard? I've not had that error, but I am using one:

  1. image

  2. image

@Dragon1573
Copy link
Contributor

Dragon1573 commented Jun 30, 2024

@Dragon1573, are you using an ASRock motherboard?

Nope ... None of my device use this motherboard.

Is ASRock motherboard required? If it is, the issue should be closed as not planned because it will never pass the validation pipelines hosted on Microsoft Azure.

Issue should be marked with Blocking-Issue Manifest validation is blocked by a known issue. and Hardware Specific hardware is required to install or validate this package .

@RokeJulianLockhart
Copy link
Contributor Author

RokeJulianLockhart commented Jun 30, 2024

#160709 (comment)

@Dragon1573, I don't know whether it does necessitate that - it was an estimate. However, this is a quite important vendor firmware updater, so it should probably be considered based upon the fact that the motherboard itself prompts the user to install it the moment that Windows is first configured - it solely being available from their website is going to cause people to accidentally install malware from similar websites higher in Google's search rankings.

@Dragon1573
Copy link
Contributor

Do you have any other devices with non-ASRock baseboard? Could you please check if this baseboard is required for running ASRock.AppShop?

image

Note

My device is a laptop bought from HUAWEI. Some packages (such as Huawei.AppGallery and Huawei.HuaweiMobileCloud) are integrated to the initial OS image and support features only available for HUAWEI hardware.

In your situation, it would be better integrate to the OS image than asking users to install themselves. Or, provide the official link directly to users instead of asking users to search themselves.

@RokeJulianLockhart
Copy link
Contributor Author

RokeJulianLockhart commented Jun 30, 2024

#160709 (comment)

@Dragon1573, I think you quite severely underestimate what would be bureaucratically necessary to integrate this into Windows, and why that would be wholly undesirable - generally the more modular an OS, the better. Irrespective, that shan't occur.

I do have another device with the exact same baseboard, and it indeed installs, but why do you ask - what does that demonstrate?

@Dragon1573
Copy link
Contributor

Dragon1573 commented Jul 1, 2024

Could you launch App Shop on that non-ASRock baseboard?

I do able to submit a manifest for this package, but I think it will mostly fail during validation.


@stephengillie , this package seems hard depends on a specific hardware (baseboard), how can we dig deeper? 🙏

image
image

I created a manifest and validated with Tools/SandboxTest.ps1, it can be successfully installed but unable to launch. Should we reject this package?

@RokeJulianLockhart
Copy link
Contributor Author

RokeJulianLockhart commented Jul 1, 2024

#160709 (comment)

@Dragon1573, I've no non-ASRock baseboard to evaluate this on. Is there no way to perform manual validation? I ask because I've recently seen myriad reports of users falling for phishing URIs when attempting to download the installer for this package (it's a fault of ASRock's hideous SEO and bad website design) so having it on WinGet would make it easier for me to recommend it.

@Dragon1573
Copy link
Contributor

Currently, the PR mentioned above pass the automatic validation. Moderators of this repository will perform manual validation with this package on Azure VMs.

Currently no responses from them. Patience are needed.

@stephengillie
Copy link
Collaborator

Unfortunately, we're not able to satisfy the hardware requirement.

@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Jul 1, 2024
@Dragon1573
Copy link
Contributor

@RokeJulianLockhart, the hardware requirements is proved. I think we can closed this issue as "not planned".

@stephengillie stephengillie removed Package-Request This is a request for a package (new or updated version) Help-Wanted This is a good candidate work item from the community. labels Jul 1, 2024
@stephengillie stephengillie added the Hardware Specific hardware is required to install or validate this package label Sep 23, 2024
Copy link
Contributor

Hello @RokeJulianLockhart,

This package appears to require specific hardware.

This package is blocked until support for specific hardware requirements is implemented in:

Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.

Template: msftbot/blockingIssue/hardwareDependency

@microsoft-github-policy-service microsoft-github-policy-service bot added the Blocking-Issue Manifest validation is blocked by a known issue. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Hardware Specific hardware is required to install or validate this package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants