-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Package Request]: ASRock.AppShop
#160709
Comments
Really weird ...
|
@Dragon1573, are you using an ASRock motherboard? I've not had that error, but I am using one: |
Nope ... None of my device use this motherboard. Is ASRock motherboard required? If it is, the issue should be closed as not planned because it will never pass the validation pipelines hosted on Microsoft Azure. Issue should be marked with
Blocking-Issue
|
@Dragon1573, I don't know whether it does necessitate that - it was an estimate. However, this is a quite important vendor firmware updater, so it should probably be considered based upon the fact that the motherboard itself prompts the user to install it the moment that Windows is first configured - it solely being available from their website is going to cause people to accidentally install malware from similar websites higher in Google's search rankings. |
Do you have any other devices with non-ASRock baseboard? Could you please check if this baseboard is required for running Note My device is a laptop bought from HUAWEI. Some packages (such as In your situation, it would be better integrate to the OS image than asking users to install themselves. Or, provide the official link directly to users instead of asking users to search themselves. |
@Dragon1573, I think you quite severely underestimate what would be bureaucratically necessary to integrate this into Windows, and why that would be wholly undesirable - generally the more modular an OS, the better. Irrespective, that shan't occur. I do have another device with the exact same baseboard, and it indeed installs, but why do you ask - what does that demonstrate? |
Could you launch App Shop on that non-ASRock baseboard? I do able to submit a manifest for this package, but I think it will mostly fail during validation. @stephengillie , this package seems hard depends on a specific hardware (baseboard), how can we dig deeper? 🙏 I created a manifest and validated with |
@Dragon1573, I've no non-ASRock baseboard to evaluate this on. Is there no way to perform manual validation? I ask because I've recently seen myriad reports of users falling for phishing URIs when attempting to download the installer for this package (it's a fault of ASRock's hideous SEO and bad website design) so having it on WinGet would make it easier for me to recommend it. |
Currently, the PR mentioned above pass the automatic validation. Moderators of this repository will perform manual validation with this package on Azure VMs. Currently no responses from them. Patience are needed. |
Unfortunately, we're not able to satisfy the hardware requirement. |
@RokeJulianLockhart, the hardware requirements is proved. I think we can closed this issue as "not planned". |
Hello @RokeJulianLockhart, This package appears to require specific hardware. This package is blocked until support for specific hardware requirements is implemented in: Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue. Template: msftbot/blockingIssue/hardwareDependency |
How can we help?
I would like someone else to build the manifest.
Please read and ensure the following
Please provide the following information
Package Requested
Please provide the following information
ASRock.AppShop
The text was updated successfully, but these errors were encountered: