Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: Itch.io #221034

Open
2 tasks done
JunZuloo opened this issue Feb 1, 2025 · 4 comments
Open
2 tasks done

[Package Issue]: Itch.io #221034

JunZuloo opened this issue Feb 1, 2025 · 4 comments
Labels
Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash In-PR Package-Update This package needs to be updated

Comments

@JunZuloo
Copy link

JunZuloo commented Feb 1, 2025

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Installer hash mismatch.

Brief description of your issue

Starting package install operation for package id=ItchIo.Itch with Manager name=Winget
Given installation options are <InstallationOptions: SkipHashCheck=False;InteractiveInstallation=False;RunAsAdministrator=True;Version=;Architecture=;InstallationScope=;InstallationScope=;CustomParameters=;RemoveDataOnUninstall=False>
Process Executable     : C:\Program Files\UniGetUI\Assets\Utilities\UniGetUI Elevator.exe
Process Call Arguments : "C:\Users\XXX\AppData\Local\Microsoft\WindowsApps\winget.exe"  install --id "ItchIo.Itch" --exact --source winget --accept-source-agreements --disable-interactivity --silent --accept-package-agreements --force
Working Directory      : C:\Users\XXX
Process Start Time     : 01/02/2025 21:42:12
Found itch [ItchIo.Itch] Version 25.5.1
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://itch.io/app/download?platform=windows
██▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  1024 KB / 13.6 MB
██████████████████████████████  13.6 MB / 13.6 MB
Installer hash does not match; this cannot be overridden when running as admin
Process Exit Code      : -1978335215
Process End Time       : 01/02/2025 21:42:17

Steps to reproduce

Actual behavior

Expected behavior

Environment

Windows Package Manager v1.9.25200
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.26100.3037
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.24.25200.0

Screenshots and Logs

No response

@JunZuloo JunZuloo added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Feb 1, 2025
Copy link

We've found some similar issues:

If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue.

Note: You can give me feedback by 👍 or 👎 this comment.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage This work item needs to be triaged by a member of the core team. Package-Update This package needs to be updated Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash and removed Issue-Bug It either shouldn't be doing this or needs an investigation. labels Feb 1, 2025
@SSLbits
Copy link
Contributor

SSLbits commented Feb 2, 2025

I am able to duplicate this issue.

Image

@SSLbits
Copy link
Contributor

SSLbits commented Feb 2, 2025

The URL does some interesting things

>  curl -IL "https://itch.io/app/download?platform=windows"
HTTP/1.1 302 Moved Temporarily
Date: Sun, 02 Feb 2025 04:02:41 GMT
Content-Type: text/html
Connection: keep-alive
Set-Cookie: itchio_token=WyJ2MWVsIiwxNzM4NDY4OTYxLCJ0djVOQTNFYTExdHluTmMiXQ%3d%3d%2eX8%2fbv2xYMP1RcuQp5d7BXTDIFLk%3d; Path=/; Domain=.itch.io; HttpOnly; Secure
X-Robots-Tag: noindex
Location: https://broth.itch.zone/install-itch/windows-386/LATEST/unpacked/default
X-Frame-Options: SAMEORIGIN
X-XSS-Protection: 1; mode=block
X-Content-Type-Options: nosniff
Referrer-Policy: no-referrer-when-downgrade
Server: lapis
X-Cache-Status: BYPASS

Unfortunately, they do not ship the desktop application installer independently. The latest itch.io desktop app stable release build is 26.1.9. This is just the itch-setup installer, 1.27.0. I've submitted a new PR here: #221096

Unless there's objections to this approach, I'll submit another PR to delete itchio.itch and resolve this issue.

@stephengillie stephengillie added In-PR and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Feb 3, 2025
@SSLbits
Copy link
Contributor

SSLbits commented Feb 5, 2025

@JunZuloo not sure if you've had a chance yet to review the discussion around some proposed changes and weigh in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash In-PR Package-Update This package needs to be updated
Projects
None yet
Development

No branches or pull requests

3 participants