Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itchcorp.itch-setup version 1.27.0 #221096

Conversation

SSLbits
Copy link
Contributor

@SSLbits SSLbits commented Feb 2, 2025

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


This is for itch-setup which is the install and self-update helper for the itch.io app, which they do not appear to ship independently. https://github.com/itchio/itch-setup
I grabbed the URLs from their build pipeline. https://broth.itch.zone/install-itch

This is related to the issue here: #221034
But this PR does not exactly fix that particular issue. I may submit another PR to delete itchio.itch after this PR is approved and merged.

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@SSLbits SSLbits mentioned this pull request Feb 2, 2025
2 tasks
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 2, 2025
@stephengillie
Copy link
Collaborator

Manual Validation ended with:
image

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Feb 3, 2025
@SSLbits
Copy link
Contributor Author

SSLbits commented Feb 5, 2025

What happens if you manually test with .\Tools\SandboxTest.ps1?
It literally just worked for me.
image

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Feb 5, 2025
@SSLbits
Copy link
Contributor Author

SSLbits commented Feb 5, 2025

I've also opened a thread on the itch dev forums asking for some guidance and best practices: https://itch.io/t/4533286/building-winget-manifests-for-itchio

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Feb 5, 2025
@stephengillie
Copy link
Collaborator

What happens if you manually test with .\Tools\SandboxTest.ps1? It literally just worked for me.

Unfortunately, I don't have the sandbox set up on my current laptop. It doesn't include enough of the Windows environment to make a good automated testing tool.

@Dragon1573
Copy link
Contributor

It stuck here for over 30 minutes ...

Note

I'm facing network problem so I'm behind a proxy as screenshot DefaultProxy.

18:06:49 D:\...\winget-pkgs  [pull/221096 +0 ~1 -0 !] 815ms pwsh$ .\Tools\SandboxTest.ps1 -Verbose
VERBOSE: Fetching release details from https://api.github.com/repos/microsoft/winget-cli/releases?per_page=100; Filters: {Prerelease=False; Version~=}
VERBOSE: Requested HTTP/1.1 GET with 0-byte payload
VERBOSE: Received HTTP/1.1 response of content type application/json of unknown size
VERBOSE: Content encoding: utf-8
VERBOSE: Parsing Release Information
VERBOSE: Fetching file hash information
VERBOSE: Requested HTTP/1.1 HEAD with 0-byte payload
VERBOSE: Received HTTP/1.1 64-byte response of content type application/octet-stream
VERBOSE: Requested HTTP/1.1 HEAD with 0-byte payload
VERBOSE: Received HTTP/1.1 64-byte response of content type application/octet-stream
VERBOSE: Building Dependency List
--> Checking Dependencies
VERBOSE: Checking the hash of C:\Users\Administrator\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\bin\v1.9.25200\DesktopAppInstaller_Dependencies.zip
VERBOSE: Checking the hash of C:\Users\Administrator\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\bin\v1.9.25200\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle
VERBOSE: Cleaning up previous test data
VERBOSE: Copying assets into C:\Users\Administrator\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\SandboxTest
VERBOSE: Creating the script for bootstrapping the sandbox
VERBOSE: Creating WSB file for launching the sandbox
--> Starting Windows Sandbox, and:
    - Mounting the following directories:
      - C:\Users\Administrator\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\SandboxTest as read-and-write
      - D:\Workloads\winget-pkgs as read-and-write
    - Installing WinGet
    - Configuring Winget
VERBOSE: Invoking the sandbox using C:\Users\Administrator\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\SandboxTest\SandboxTest.wsb
18:07:04 D:\...\winget-pkgs  [pull/221096 +0 ~1 -0 !] 13.506s pwsh$  # Time here is the finish/interrupt/corrupt time of the last command

image

@SSLbits
Copy link
Contributor Author

SSLbits commented Feb 9, 2025

I'm just going to close this since it can't be reconciled.

@SSLbits SSLbits closed this Feb 9, 2025
auto-merge was automatically disabled February 9, 2025 05:10

Pull request was closed

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. New-Package Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants