Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: WildfireGames.0AD | 0.0.24b is detected as update for r25860-alpha #56595

Closed
2 tasks done
Sky-NiniKo opened this issue Apr 2, 2022 · 1 comment · Fixed by #56602
Closed
2 tasks done
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@Sky-NiniKo
Copy link
Contributor

Sky-NiniKo commented Apr 2, 2022

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

Winget wants to upgrade to 0.0.24b while 25860-alpha is installed.
NB: r25860-alpha is the name of version 0.0.25b. I don't know why it's called that but it is.

Steps to reproduce

Have version 0.0.25b installed and try to update.

Actual behavior

Update to 0.0.24b.

Expected behavior

Do not update.

Environment

Windows Package Manager v1.2.10271
Windows: Windows.Desktop v10.0.19043.1586
Package: Microsoft.DesktopAppInstaller v1.17.10271.0

0 A.D.: v0.0.25b

Screenshots and Logs

PS C:\Users\User> winget upgrade
Name                                                 ID                                     Version        Available      Source
--------------------------------------------------------------------------------------------------------------------------------
0 A.D.                                               WildfireGames.0AD                      r25860-alpha   0.0.24b        winget


PS C:\Users\User> winget upgrade 0ad
Found 0 A.D. [WildfireGames.0AD] Version 0.0.24b
The license to use this application is granted to you by its owner.
Microsoft is not responsible for and does not license third-party packages.
Downloading https://releases.wildfiregames.com/0ad-0.0.24b-alpha-win32.exe
  ██████████████████████████████  0.00 B /  845 MB
Package download canceled.
@Sky-NiniKo Sky-NiniKo added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Apr 2, 2022
@ghost ghost added the Needs-Triage This work item needs to be triaged by a member of the core team. label Apr 2, 2022
@Trenly
Copy link
Contributor

Trenly commented Apr 2, 2022

It seems that when 0.0.24b was added, the version wasn't set to what is shown in the Add/Remove Programs (ARP) Table, which is causing this mismatch.

I've created the above PR which should solve the issue of there being an upgrade reported;

NB: r25860-alpha is the name of version 0.0.25b. I don't know why it's called that but it is.

It is called that because that is what the version is set to in the ARP table

DisplayName DisplayVersion Publisher      ProductCode
----------- -------------- ---------      -----------
0 A.D.      r25860-alpha   Wildfire Games 0 A.D.

Unfortunately, the 0.0.24b and ``0.0.25b` etc. are "Marketing Versions", meaning that is what is stated the version is, but it isn't the version that is reported. Once microsoft/winget-cli#1952 is implemented, it will make it easier to differentiate between the marketing versions and reported versions, but as of right now we have to use the reported version.

@ghost ghost closed this as completed in #56602 Apr 2, 2022
@denelon denelon removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Nov 1, 2023
@denelon denelon added this to the 1.7 Packages milestone Nov 1, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants