Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEEYOU.SEEYOU version 2.0.2 #101232

Conversation

khaffner
Copy link
Contributor

@khaffner khaffner commented Mar 31, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Mar 31, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @khaffner,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@BrandonWanHuanSheng
Copy link
Contributor

Configuring the installer...

@BrandonWanHuanSheng
Copy link
Contributor

This is most likely like Fiddler Setup. I am going to get the silent switch.

@BrandonWanHuanSheng
Copy link
Contributor

No silent switches, The installer type supposed nullsoft. I am going to check if there is any dependent services.

@khaffner
Copy link
Contributor Author

/allusers /S

Might work

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 31, 2023
@BrandonWanHuanSheng
Copy link
Contributor

I seeing a lot of cmd pop up while during uninstall.

@BrandonWanHuanSheng
Copy link
Contributor

/allusers /S

Might work

Yes

@stephengillie
Copy link
Collaborator

stephengillie commented Mar 31, 2023

Hi @khaffner,

The installation isn't unattended:
image

Is there an installer switch to bypass this and have it install without rebooting?

Edit: I tried both /S and /noreboot but neither prevented the prompt.

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Mar 31, 2023
@BrandonWanHuanSheng
Copy link
Contributor

BrandonWanHuanSheng commented Apr 1, 2023

I also noticed that one but norestart did not work. Normally the command is used when using updating cab and msu when trying to skip this dialog. It also use in exe application. Norestart usually suppresses automatic reboots and reboot prompts.

@BrandonWanHuanSheng
Copy link
Contributor

I guess it might be NR. Still No Work.

@BrandonWanHuanSheng
Copy link
Contributor

I found the help usage https://nsis.sourceforge.io/Docs/Chapter3.html

@BrandonWanHuanSheng
Copy link
Contributor

@khaffner, I found the help file. https://nsis.sourceforge.io/Docs/Chapter3.html

@BrandonWanHuanSheng
Copy link
Contributor

BrandonWanHuanSheng commented Apr 1, 2023

@stephengillie It look like the installer is not unattended. But I actually tried every command, the reboot dialog keep popping up. There is no ways to resolve.

@stephengillie
Copy link
Collaborator

@stephengillie It look like the installer is not unattended. But I actually tried every command, the reboot dialog keep popping up. There is no ways to resolve.

Pending:

@stephengillie stephengillie removed the Needs-Author-Feedback This needs a response from the author. label Apr 3, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @khaffner,

This package appears to require user interaction to install.

This PR is blocked until support for interactive installer search filtering is implemented in:

Template: msftbot/blockingIssue/interactiveOnlyInstall

@microsoft-github-policy-service microsoft-github-policy-service bot added the Blocking-Issue Manifest validation is blocked by a known issue. label Apr 3, 2023
@BrandonWanHuanSheng
Copy link
Contributor

BrandonWanHuanSheng commented Apr 4, 2023

Closed #101232

Result: Failure to interactive install because this installer does not accept NoRestart and NoReboot Command.

@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Dec 7, 2023
Copy link
Contributor

Hello @khaffner,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Interactive-Only-Installer No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants