Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix x64 binary url to Microsoft.AzureCLI v 2.52.0 #119228

Merged
merged 2 commits into from
Sep 10, 2023
Merged

fix x64 binary url to Microsoft.AzureCLI v 2.52.0 #119228

merged 2 commits into from
Sep 10, 2023

Conversation

kkamegawa
Copy link
Contributor

@kkamegawa kkamegawa commented Sep 9, 2023 •
edited by microsoft-github-policy-service bot
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest .\manifests\m\Microsoft\Azurecli\2.52.0?
  • Have you tested your manifest locally with winget install --manifest .\manifests\m\Microsoft\Azurecli\2.52.0?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 9, 2023
@microsoft-github-policy-service
Copy link
Contributor

kkamegawa,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

mdanish-kh
mdanish-kh suggested changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@mdanish-kh mdanish-kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProductCode helps with package correlation for MSI packages

manifests/m/Microsoft/AzureCLI/2.52.0/Microsoft.AzureCLI.installer.yaml Show resolved Hide resolved
manifests/m/Microsoft/AzureCLI/2.52.0/Microsoft.AzureCLI.installer.yaml Show resolved Hide resolved
@microsoft-github-policy-service
Copy link
Contributor

Hello @kkamegawa,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 9, 2023
auto-merge was automatically disabled September 10, 2023 03:07

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. labels Sep 10, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 10, 2023
@microsoft-github-policy-service
Copy link
Contributor

kkamegawa,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

mdanish-kh
mdanish-kh approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@mdanish-kh mdanish-kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkamegawa Please mark the above conversations as "resolved" for auto-merge process to merge this PR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 10, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello kkamegawa,
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Sep 10, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello kkamegawa,
Validation has completed.

Template: msftbot/validationCompleted

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 8bee922 into microsoft:master Sep 10, 2023
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@kkamegawa kkamegawa deleted the Microsoft.Azure.Cli.2.52.0.x64 branch September 25, 2023 11:28
@halter73 halter73 mentioned this pull request Oct 24, 2023
Merged
@jiasli jiasli mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

@mdanish-kh mdanish-kh mdanish-kh approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkamegawa @wingetbot @mdanish-kh