Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileOpen.FileOpen version 3.0.176.998 #121663

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Oct 2, 2023

Resolve #121595 .

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?
  • Have you tested your manifest in Windows Sandbox with Tools/SandboxTest.ps1 -Manifest <path>?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Oct 2, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Oct 2, 2023
@Dragon1573
Copy link
Contributor Author

While testing in Windows Sandbox, winget.exe prompts out an interactive requirements that user should explicitly agree the source agreements terms of msstore source.

Logs from Windows Sandbox
PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget install -m .\manifests\f\FileOpen\FileOpen\3.0.176.998\
Found FileOpen Client (x64) B998 [FileOpen.FileOpen] Version 3.0.176.998
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
The `msstore` source requires that you view the following agreements before using.
Terms of Transaction: https://aka.ms/microsoft-store-terms-of-transaction
The source requires the current machine's 2-letter geographic region to be sent to the backend service to function properly (ex. "US").

Do you agree to all the source agreements terms?
[Y] Yes  [N] No: Y
This package requires the following dependencies:
  - Packages
      Adobe.Acrobat.Reader.64-bit
Installing dependencies:
(1/1) Found Adobe Acrobat Reader DC (64-bit) [Adobe.Acrobat.Reader.64-bit] Version 23.006.20320
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://ardownload2.adobe.com/pub/adobe/acrobat/win/AcrobatDC/2300620320/AcroRdrDCx642300620320_MUI.exe
  ██████████████████████████████   422 MB /  422 MB
Successfully verified installer hash
Starting package install...
Successfully installed

Downloading https://plugin.fileopen.com/current/FileOpenInstaller.exe
  ██████████████████████████████  6.51 MB / 6.51 MB
Successfully verified installer hash
Starting package install...
Successfully installed
PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs>

Maybe the Azure Pipelines blocked here for Validation-Unattended-Failed? How can I agree the terms silently?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 2, 2023
@freddyboy1974
Copy link

Hi, sorry, I don't understand if you need more info from my part. If so, if you want me to open a case with the publisher, i'd be glad to help and submit any issue you ask me to contact support with.

@Dragon1573
Copy link
Contributor Author

Thank you @freddyboy1974 !

The above question is for winget-pkgs contributors & collaborators, not for FileOpen Plugin itself. No need for further informations of FileOpen Plugin Client.


There are some complicated situations to handle with the manifests:

  1. winget.exe require users to explicitly agree with the msstore source agreements terms. Which may cause Validation-Unattended-Failed label from @wingetbot .
  2. FileOpen Plugin Client require Adobe Acrobat Reader or DC Pro 9+ as dependencies.
  3. When configuring Adobe Acrobat Reader 9 (x64) as a "Package Dependency" of FileOpen Plugin Client, winget.exe will ONLY skip dependency installation when the exact package Adobe.Acrobat.Reader.64-bit is previously installed by user. This may cause package duplications.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. labels Oct 3, 2023
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Oct 3, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Oct 3, 2023
- Maybe the MSI file is NOT packaged by wix.
- Official team prefer EXE installer rather than MSI one.
- Try again if the EXE file can pass the Azure Pipeline tests.

Signed-off-by: Dragon1573 <49941141+Dragon1573@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Oct 3, 2023
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Oct 3, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Oct 3, 2023
@Trenly
Copy link
Contributor

Trenly commented Oct 3, 2023

winget.exe require users to explicitly agree with the msstore source agreements terms. Which may cause Validation-Unattended-Failed label from @wingetbot .

This doesn't affect the pipelines at all, since the tests are executed in an isolated environment

FileOpen Plugin Client require Adobe Acrobat Reader or DC Pro 9+ as dependencies.

Dependencies aren't enabled in the pipelines yet, this is what is causing the unattended label

@microsoft-github-policy-service microsoft-github-policy-service bot added Dependencies Blocking-Issue Manifest validation is blocked by a known issue. labels Oct 3, 2023
@Dragon1573
Copy link
Contributor Author

It seems that microsoft/winget-cli#163 is solved and closed on Aug 30. I can't understand microsoft/winget-cli#163 (comment) in that issue.

Dependencies aren't enabled in the pipelines yet.

Could you please explain more?


Currently convert this PR to "Draft" and wait for the implementation.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 3, 2023
@Dragon1573 Dragon1573 marked this pull request as draft October 3, 2023 17:02
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Oct 4, 2023
@Trenly
Copy link
Contributor

Trenly commented Oct 4, 2023

Could you please explain more?

Dependencies are still an experimental feature until the 1.6 client. Currently, the validation pipeline runs the 1.4 client. This is to ensure that the newer 1.6 version has enough time to roll out to users. It may be a few days or weeks before manifests that have dependencies are able to be automatically processed.

@Dragon1573 Dragon1573 marked this pull request as ready for review October 7, 2023 08:16
@Dragon1573
Copy link
Contributor Author

Switch status as "Ready for review". As PR #101086 also requires dependencies, but it passed Azure Pipelines and successfully merged.

@Dragon1573 Dragon1573 removed their assignment Oct 7, 2023
@Dragon1573
Copy link
Contributor Author

/AzurePipelines run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 121663 in repo microsoft/winget-pkgs

@Dragon1573
Copy link
Contributor Author

Seems nobody are interested in this pull request, and this version may be outdated.

Close as rejected.

@Dragon1573 Dragon1573 closed this Nov 14, 2023
@Dragon1573 Dragon1573 deleted the FileOpen.FileOpen-3.0.176.998-b37249e2-a675-4b45-8d1d-58f975521141 branch November 14, 2023 13:39
@tlourey
Copy link

tlourey commented Nov 17, 2023

Bugger, I came here hoping this wouldn't need to much to finish. @Dragon1573 , any change your willing to submit again?

@Dragon1573
Copy link
Contributor Author

This package requires Adobe Acrobat series as dependency, which is currently not available for Azure Pipelines.

You can simply copy 3 files from my PR, and submit to this repository for a new PR. I think pipelines will failed as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Dependencies Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: FileOPen Plug In
7 participants